From 7169b270ae62d7bfcc28da27433a313b0f3c4610 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Mon, 10 Mar 2025 04:17:02 -0400
Subject: [PATCH] Convert `admin/site_uploads` spec controller->system (#34108)

---
 .../admin/site_uploads_controller_spec.rb     | 23 ----------------
 spec/system/admin/site_uploads_spec.rb        | 27 +++++++++++++++++++
 2 files changed, 27 insertions(+), 23 deletions(-)
 delete mode 100644 spec/controllers/admin/site_uploads_controller_spec.rb
 create mode 100644 spec/system/admin/site_uploads_spec.rb

diff --git a/spec/controllers/admin/site_uploads_controller_spec.rb b/spec/controllers/admin/site_uploads_controller_spec.rb
deleted file mode 100644
index 1fe5903498..0000000000
--- a/spec/controllers/admin/site_uploads_controller_spec.rb
+++ /dev/null
@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-RSpec.describe Admin::SiteUploadsController do
-  render_views
-
-  let(:user) { Fabricate(:admin_user) }
-
-  before do
-    sign_in user, scope: :user
-  end
-
-  describe 'DELETE #destroy' do
-    let(:site_upload) { Fabricate(:site_upload, var: 'thumbnail') }
-
-    it 'returns http success' do
-      delete :destroy, params: { id: site_upload.id }
-
-      expect(response).to redirect_to(admin_settings_path)
-    end
-  end
-end
diff --git a/spec/system/admin/site_uploads_spec.rb b/spec/system/admin/site_uploads_spec.rb
new file mode 100644
index 0000000000..5cbd8d275c
--- /dev/null
+++ b/spec/system/admin/site_uploads_spec.rb
@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe 'Admin SiteUploads' do
+  let(:user) { Fabricate(:admin_user) }
+
+  before { sign_in(user) }
+
+  describe 'Removing a site upload' do
+    let!(:site_upload) { Fabricate(:site_upload, var: 'thumbnail') }
+
+    it 'removes the upload and redirects' do
+      visit admin_settings_branding_path
+      expect(page)
+        .to have_title(I18n.t('admin.settings.branding.title'))
+
+      expect { click_on I18n.t('admin.site_uploads.delete') }
+        .to change(SiteUpload, :count).by(-1)
+      expect { site_upload.reload }
+        .to raise_error(ActiveRecord::RecordNotFound)
+      expect(page)
+        .to have_content(I18n.t('admin.site_uploads.destroyed_msg'))
+        .and have_title(I18n.t('admin.settings.branding.title'))
+    end
+  end
+end