0
0
Fork 0

Fix RSpec/ContextWording cop (#24739)

This commit is contained in:
Matt Jankowski 2023-05-03 23:49:08 -04:00 committed by GitHub
parent cf18cc2891
commit 710745e16b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
105 changed files with 559 additions and 668 deletions

View file

@ -9,7 +9,7 @@ RSpec.describe InvitePolicy do
let(:john) { Fabricate(:user).account }
permissions :index? do
context 'staff?' do
context 'when staff?' do
it 'permits' do
expect(subject).to permit(admin, Invite)
end
@ -17,7 +17,7 @@ RSpec.describe InvitePolicy do
end
permissions :create? do
context 'has privilege' do
context 'with privilege' do
before do
UserRole.everyone.update(permissions: UserRole::FLAGS[:invite_users])
end
@ -27,7 +27,7 @@ RSpec.describe InvitePolicy do
end
end
context 'does not have privilege' do
context 'when does not have privilege' do
before do
UserRole.everyone.update(permissions: UserRole::Flags::NONE)
end
@ -39,13 +39,13 @@ RSpec.describe InvitePolicy do
end
permissions :deactivate_all? do
context 'admin?' do
context 'when admin?' do
it 'permits' do
expect(subject).to permit(admin, Invite)
end
end
context 'not admin?' do
context 'when not admin?' do
it 'denies' do
expect(subject).to_not permit(john, Invite)
end
@ -53,20 +53,20 @@ RSpec.describe InvitePolicy do
end
permissions :destroy? do
context 'owner?' do
context 'when owner?' do
it 'permits' do
expect(subject).to permit(john, Fabricate(:invite, user: john.user))
end
end
context 'not owner?' do
context 'admin?' do
context 'when not owner?' do
context 'when admin?' do
it 'permits' do
expect(subject).to permit(admin, Fabricate(:invite))
end
end
context 'not admin?' do
context 'when not admin?' do
it 'denies' do
expect(subject).to_not permit(john, Fabricate(:invite))
end