Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix URLs incorrectly having trailing hyphen removed (#6465)

Browse source 
In cases where a URL has a trailing hyphen the FetchLinkCardService incorrectly removes the hyphen when it is parsed

The hyphen is not a reserved character in the URI spec https://tools.ietf.org/html/rfc3986#section-2.2
This commit is contained in:
Daniel King 2018-02-11 22:49:18 +00:00 • committed by Eugen Rochko
parent e20700fe8f
commit 6ef3874b2e
2 changed files with 11 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
config/initializers/twitter_regex.rb
View file

@ -2,7 +2,7 @@ module Twitter
class Regex
REGEXEN[:valid_general_url_path_chars] = /[^\p{White_Space}\(\)\?]/iou
REGEXEN[:valid_url_path_ending_chars] = /[^\p{White_Space}\(\)\?!\*';:=\,\.\$%\[\]\p{Pd}~&\|@]|(?:#{REGEXEN[:valid_url_balanced_parens]})/iou
REGEXEN[:valid_url_path_ending_chars] = /[^\p{White_Space}\(\)\?!\*';:=\,\.\$%\[\]~&\|@]|(?:#{REGEXEN[:valid_url_balanced_parens]})/iou
REGEXEN[:valid_url_balanced_parens] = /
\(
(?: