0
0
Fork 0

Fix spec descriptions around configurable limit values (#31079)

This commit is contained in:
Matt Jankowski 2024-07-22 04:02:31 -04:00 committed by GitHub
parent 5a60a3b80c
commit 6e4305de69
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 30 additions and 13 deletions

View file

@ -42,23 +42,23 @@ describe StatusLengthValidator do
expect(status.errors).to have_received(:add)
end
it 'counts URLs as 23 characters flat' do
text = ('a' * 476) + " http://#{'b' * 30}.com/example"
it 'reduces calculated length of auto-linkable space-separated URLs' do
text = [starting_string, example_link].join(' ')
status = status_double(text: text)
subject.validate(status)
expect(status.errors).to_not have_received(:add)
end
it 'does not count non-autolinkable URLs as 23 characters flat' do
text = ('a' * 476) + "http://#{'b' * 30}.com/example"
it 'does not reduce calculated length of non-autolinkable URLs' do
text = [starting_string, example_link].join
status = status_double(text: text)
subject.validate(status)
expect(status.errors).to have_received(:add)
end
it 'does not count overly long URLs as 23 characters flat' do
it 'does not reduce calculated length of count overly long URLs' do
text = "http://example.com/valid?#{'#foo?' * 1000}"
status = status_double(text: text)
subject.validate(status)
@ -84,6 +84,14 @@ describe StatusLengthValidator do
private
def starting_string
'a' * 476
end
def example_link
"http://#{'b' * 30}.com/example"
end
def status_double(spoiler_text: '', text: '')
instance_double(
Status,