Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Raise an error for remote url in StatusFinder (#4776)

Browse source 
* Raise an error for remote url in StatusFinder

Previous implementation had allowed remote url with status id which also exists on local.

Then that bug leads /api/web/embed to return wrong embed url.

* Fix oembed_controller_spec
This commit is contained in:
unarist 2017-09-03 00:42:47 +09:00 • committed by Eugen Rochko
parent bfa7f9ebf2
commit 6a4e2db661
3 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/lib/status_finder.rb
View file

@ -10,6 +10,8 @@ class StatusFinder
def status
verify_action!
raise ActiveRecord::RecordNotFound unless TagManager.instance.local_url?(url)
case recognized_params[:controller]
when 'stream_entries'
StreamEntry.find(recognized_params[:id]).status