Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Update twitter-text from 1.14 to 3.1.0 and fix toot character counting (#15382)

Browse source 
* Update twitter-text from 1.14 to 3.1.0

* Disable emoji parsing

* Properly depend on twitter-text for url detection

* Fix some URLs being wrongly detected client-side

* Add test for server-side validation of non-autolinkable URLs

* Fix server-side status length counting
This commit is contained in:
Claire 2021-03-02 12:02:56 +01:00 • committed by GitHub
parent a8139ab016
commit 65db262550
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 99 additions and 214 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec/validators/status_length_validator_spec.rb
View file

@ -42,6 +42,14 @@ describe StatusLengthValidator do
expect(status.errors).to_not have_received(:add)
end
it 'does not count non-autolinkable URLs as 23 characters flat' do
text = ('a' * 476) + "http://#{'b' * 30}.com/example"
status = double(spoiler_text: '', text: text, errors: double(add: nil), local?: true, reblog?: false)
subject.validate(status)
expect(status.errors).to have_received(:add)
end
it 'counts only the front part of remote usernames' do
text = ('a' * 475) + " @alice@#{'b' * 30}.com"
status = double(spoiler_text: '', text: text, errors: double(add: nil), local?: true, reblog?: false)