Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix email confirmation link not updating email (#6187)

Browse source 
A change introduced in #6125 prevents
`Devise::Models::Confirmable#confirm` from being called for existing
users, which in turn leads to `email` not being set to
`unconfirmed_email`, breaking email updates. This also adds a test
that would've caught this issue.
This commit is contained in:
Patrick Figel 2018-01-05 00:15:35 +01:00 • committed by Eugen Rochko
parent 49e296e1b0
commit 5ec25ff3e1
3 changed files with 42 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec/models/user_spec.rb
View file

@ -148,6 +148,14 @@ RSpec.describe User, type: :model do
end
end
describe '#confirm' do
it 'sets email to unconfirmed_email' do
user = Fabricate.build(:user, confirmed_at: Time.now.utc, unconfirmed_email: 'new-email@example.com')
user.confirm
expect(user.email).to eq 'new-email@example.com'
end
end
describe '#disable_two_factor!' do
it 'saves false for otp_required_for_login' do
user = Fabricate.build(:user, otp_required_for_login: true)