Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Remove usage of assigns in controller specs (#30195)

Browse source
This commit is contained in:
Matt Jankowski 2024-09-03 11:23:16 -04:00 • committed by GitHub
parent ae363f0555
commit 5b595b8a5a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 66 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

8
spec/controllers/settings/imports_controller_spec.rb
View file

@ -21,9 +21,10 @@ RSpec.describe Settings::ImportsController do
it 'assigns the expected imports', :aggregate_failures do
expect(response).to have_http_status(200)
expect(assigns(:recent_imports)).to eq [import]
expect(assigns(:recent_imports)).to_not include(other_import)
expect(response.headers['Cache-Control']).to include('private, no-store')
expect(response.body)
.to include("bulk_import_#{import.id}")
.and not_include("bulk_import_#{other_import.id}")
end
end
@ -261,7 +262,8 @@ RSpec.describe Settings::ImportsController do
it 'does not creates an unconfirmed bulk_import', :aggregate_failures do
expect { subject }.to_not(change { user.account.bulk_imports.count })
expect(assigns(:import).errors).to_not be_empty
expect(response.body)
.to include('field_with_errors')
end
end