Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Simplify basic presence validations (#29664)

Browse source
This commit is contained in:
Matt Jankowski 2024-09-05 11:36:05 -04:00 • committed by GitHub
parent bc435c63bd
commit 5acec087ca
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 28 additions and 159 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec/models/announcement_spec.rb
View file

@ -64,14 +64,7 @@ RSpec.describe Announcement do
end
describe 'Validations' do
describe 'text' do
it 'validates presence of attribute' do
record = Fabricate.build(:announcement, text: nil)
expect(record).to_not be_valid
expect(record.errors[:text]).to be_present
end
end
it { is_expected.to validate_presence_of(:text) }
describe 'ends_at' do
it 'validates presence when starts_at is present' do