Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix error when rendering public pages with media attachments (#16763)

Browse source 
* Add tests

* Fix error when rendering public pages with media attachments

* Add tests

* Fix tests

* Please CodeClimate
This commit is contained in:
Claire 2021-10-13 15:27:19 +02:00 • committed by GitHub
parent 8818622feb
commit 5159ba26e4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 102 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

20
spec/models/media_attachment_spec.rb
View file

@ -62,11 +62,23 @@ RSpec.describe MediaAttachment, type: :model do
end
describe '#to_param' do
let(:media_attachment) { Fabricate(:media_attachment) }
let(:shortcode) { media_attachment.shortcode }
let(:media_attachment) { Fabricate(:media_attachment, shortcode: shortcode) }
let(:shortcode) { nil }
it 'returns shortcode' do
expect(media_attachment.to_param).to eq shortcode
context 'when media attachment has a shortcode' do
let(:shortcode) { 'foo' }
it 'returns shortcode' do
expect(media_attachment.to_param).to eq shortcode
end
end
context 'when media attachment does not have a shortcode' do
let(:shortcode) { nil }
it 'returns string representation of id' do
expect(media_attachment.to_param).to eq media_attachment.id.to_s
end
end
end