Autofix Rubocop RSpec/BeEq (#23740)
This commit is contained in:
parent
bf785df9fe
commit
5116347eb7
39 changed files with 139 additions and 182 deletions
|
@ -3,13 +3,13 @@
|
|||
shared_examples 'ScopedSettings' do
|
||||
describe '[]' do
|
||||
it 'inherits default settings' do
|
||||
expect(Setting.boost_modal).to eq false
|
||||
expect(Setting.interactions['must_be_follower']).to eq false
|
||||
expect(Setting.boost_modal).to be false
|
||||
expect(Setting.interactions['must_be_follower']).to be false
|
||||
|
||||
settings = create!
|
||||
|
||||
expect(settings['boost_modal']).to eq false
|
||||
expect(settings['interactions']['must_be_follower']).to eq false
|
||||
expect(settings['boost_modal']).to be false
|
||||
expect(settings['interactions']['must_be_follower']).to be false
|
||||
end
|
||||
end
|
||||
|
||||
|
@ -17,16 +17,16 @@ shared_examples 'ScopedSettings' do
|
|||
# expecting [] and []= works
|
||||
|
||||
it 'returns records merged with default values except hashes' do
|
||||
expect(Setting.boost_modal).to eq false
|
||||
expect(Setting.delete_modal).to eq true
|
||||
expect(Setting.boost_modal).to be false
|
||||
expect(Setting.delete_modal).to be true
|
||||
|
||||
settings = create!
|
||||
settings['boost_modal'] = true
|
||||
|
||||
records = settings.all_as_records
|
||||
|
||||
expect(records['boost_modal'].value).to eq true
|
||||
expect(records['delete_modal'].value).to eq true
|
||||
expect(records['boost_modal'].value).to be true
|
||||
expect(records['delete_modal'].value).to be true
|
||||
end
|
||||
end
|
||||
|
||||
|
@ -34,15 +34,15 @@ shared_examples 'ScopedSettings' do
|
|||
# expecting [] and []= works.
|
||||
|
||||
it 'reads settings' do
|
||||
expect(Setting.boost_modal).to eq false
|
||||
expect(Setting.boost_modal).to be false
|
||||
settings = create!
|
||||
expect(settings.boost_modal).to eq false
|
||||
expect(settings.boost_modal).to be false
|
||||
end
|
||||
|
||||
it 'updates settings' do
|
||||
settings = fabricate
|
||||
settings.boost_modal = true
|
||||
expect(settings['boost_modal']).to eq true
|
||||
expect(settings['boost_modal']).to be true
|
||||
end
|
||||
end
|
||||
|
||||
|
@ -54,13 +54,13 @@ shared_examples 'ScopedSettings' do
|
|||
|
||||
Setting.save!
|
||||
|
||||
expect(settings['boost_modal']).to eq true
|
||||
expect(settings['interactions']['must_be_follower']).to eq true
|
||||
expect(settings['boost_modal']).to be true
|
||||
expect(settings['interactions']['must_be_follower']).to be true
|
||||
|
||||
Rails.cache.clear
|
||||
|
||||
expect(settings['boost_modal']).to eq true
|
||||
expect(settings['interactions']['must_be_follower']).to eq true
|
||||
expect(settings['boost_modal']).to be true
|
||||
expect(settings['interactions']['must_be_follower']).to be true
|
||||
end
|
||||
|
||||
xit 'does not mutate defaults via the cache' do
|
||||
|
@ -69,6 +69,6 @@ shared_examples 'ScopedSettings' do
|
|||
# This mutates the global settings default such that future
|
||||
# instances will inherit the incorrect starting values
|
||||
|
||||
expect(fabricate.settings['interactions']['must_be_follower']).to eq false
|
||||
expect(fabricate.settings['interactions']['must_be_follower']).to be false
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue