Fix #52 - Add API versioning (v1)

spec/controllers/api/v1/accounts_controller_spec.rb

@@ -0,0 +1,116 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::AccountsController, type: :controller do
+  render_views
+
+  let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+  let(:token) { double acceptable?: true, resource_owner_id: user.id }
+
+  before do
+    stub_request(:post, "https://pubsubhubbub.superfeedr.com/").to_return(:status => 200, :body => "", :headers => {})
+    allow(controller).to receive(:doorkeeper_token) { token }
+  end
+
+  describe 'GET #show' do
+    it 'returns http success' do
+      get :show, params: { id: user.account.id }
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'GET #statuses' do
+    it 'returns http success' do
+      get :statuses, params: { id: user.account.id }
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'GET #followers' do
+    it 'returns http success' do
+      get :followers, params: { id: user.account.id }
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'GET #following' do
+    it 'returns http success' do
+      get :following, params: { id: user.account.id }
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'POST #follow' do
+    let(:other_account) { Fabricate(:user, email: 'bob@example.com', account: Fabricate(:account, username: 'bob')).account }
+
+    before do
+      post :follow, params: { id: other_account.id }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'creates a following relation between user and target user' do
+      expect(user.account.following?(other_account)).to be true
+    end
+  end
+
+  describe 'POST #unfollow' do
+    let(:other_account) { Fabricate(:user, email: 'bob@example.com', account: Fabricate(:account, username: 'bob')).account }
+
+    before do
+      user.account.follow!(other_account)
+      post :unfollow, params: { id: other_account.id }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'removes the following relation between user and target user' do
+      expect(user.account.following?(other_account)).to be false
+    end
+  end
+
+  describe 'GET #relationships' do
+    let(:simon) { Fabricate(:user, email: 'simon@example.com', account: Fabricate(:account, username: 'simon')).account }
+    let(:lewis) { Fabricate(:user, email: 'lewis@example.com', account: Fabricate(:account, username: 'lewis')).account }
+
+    before do
+      user.account.follow!(simon)
+      lewis.follow!(user.account)
+    end
+
+    context 'provided only one ID' do
+      before do
+        get :relationships, params: { id: simon.id }
+      end
+
+      it 'returns http success' do
+        expect(response).to have_http_status(:success)
+      end
+
+      it 'returns JSON with correct data' do
+        json = body_as_json
+
+        expect(json).to be_a Enumerable
+        expect(json.first[:following]).to be true
+        expect(json.first[:followed_by]).to be false
+      end
+    end
+
+    context 'provided multiple IDs' do
+      before do
+        get :relationships, params: { id: [simon.id, lewis.id] }
+      end
+
+      it 'returns http success' do
+        expect(response).to have_http_status(:success)
+      end
+
+      xit 'returns JSON with correct data' do
+        # todo
+      end
+    end
+  end
+end

spec/controllers/api/v1/apps_controller_spec.rb

@@ -0,0 +1,26 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::AppsController, type: :controller do
+  render_views
+
+  describe 'POST #create' do
+    before do
+      post :create, params: { name: 'Test app', redirect_uri: 'urn:ietf:wg:oauth:2.0:oob' }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'creates an OAuth app' do
+      expect(Doorkeeper::Application.find_by(name: 'Test app')).to_not be nil
+    end
+
+    it 'returns client ID and client secret' do
+      json = body_as_json
+
+      expect(json[:client_id]).to_not be_blank
+      expect(json[:client_secret]).to_not be_blank
+    end
+  end
+end

spec/controllers/api/v1/follows_controller_spec.rb

@@ -0,0 +1,50 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::FollowsController, type: :controller do
+  render_views
+
+  let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+  let(:token) { double acceptable?: true, resource_owner_id: user.id }
+
+  before do
+    allow(controller).to receive(:doorkeeper_token) { token }
+  end
+
+  describe 'POST #create' do
+    before do
+      stub_request(:get,  "https://quitter.no/.well-known/host-meta").to_return(request_fixture('.host-meta.txt'))
+      stub_request(:get,  "https://quitter.no/.well-known/webfinger?resource=acct:gargron@quitter.no").to_return(request_fixture('webfinger.txt'))
+      stub_request(:get,  "https://quitter.no/api/statuses/user_timeline/7477.atom").to_return(request_fixture('feed.txt'))
+      stub_request(:get,  "https://quitter.no/avatar/7477-300-20160211190340.png").to_return(request_fixture('avatar.txt'))
+      stub_request(:post, "https://quitter.no/main/push/hub").to_return(:status => 200, :body => "", :headers => {})
+      stub_request(:post, "https://quitter.no/main/salmon/user/7477").to_return(:status => 200, :body => "", :headers => {})
+      stub_request(:post, "https://pubsubhubbub.superfeedr.com/").to_return(:status => 200, :body => "", :headers => {})
+
+      post :create, params: { uri: 'gargron@quitter.no' }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'creates account for remote user' do
+      expect(Account.find_by(username: 'gargron', domain: 'quitter.no')).to_not be_nil
+    end
+
+    it 'creates a follow relation between user and remote user' do
+      expect(user.account.following?(Account.find_by(username: 'gargron', domain: 'quitter.no'))).to be true
+    end
+
+    it 'sends a salmon slap to the remote user' do
+      expect(a_request(:post, "https://quitter.no/main/salmon/user/7477")).to have_been_made
+    end
+
+    it 'notifies own hub' do
+      expect(a_request(:post, "https://pubsubhubbub.superfeedr.com/")).to have_been_made
+    end
+
+    it 'subscribes to remote hub' do
+      expect(a_request(:post, "https://quitter.no/main/push/hub")).to have_been_made
+    end
+  end
+end

spec/controllers/api/v1/media_controller_spec.rb

@@ -0,0 +1,58 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::MediaController, type: :controller do
+  render_views
+
+  let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+  let(:token) { double acceptable?: true, resource_owner_id: user.id }
+
+  before do
+    allow(controller).to receive(:doorkeeper_token) { token }
+  end
+
+  describe 'POST #create' do
+    context 'image/jpeg' do
+      before do
+        post :create, params: { file: fixture_file_upload('files/attachment.jpg', 'image/jpeg') }
+      end
+
+      it 'returns http success' do
+        expect(response).to have_http_status(:success)
+      end
+
+      it 'creates a media attachment' do
+        expect(MediaAttachment.first).to_not be_nil
+      end
+
+      it 'uploads a file' do
+        expect(MediaAttachment.first).to have_attached_file(:file)
+      end
+
+      it 'returns media ID in JSON' do
+        expect(body_as_json[:id]).to eq MediaAttachment.first.id
+      end
+    end
+
+    context 'video/webm' do
+      before do
+        post :create, params: { file: fixture_file_upload('files/attachment.webm', 'video/webm') }
+      end
+
+      xit 'returns http success' do
+        expect(response).to have_http_status(:success)
+      end
+
+      xit 'creates a media attachment' do
+        expect(MediaAttachment.first).to_not be_nil
+      end
+
+      xit 'uploads a file' do
+        expect(MediaAttachment.first).to have_attached_file(:file)
+      end
+
+      xit 'returns media ID in JSON' do
+        expect(body_as_json[:id]).to eq MediaAttachment.first.id
+      end
+    end
+  end
+end

spec/controllers/api/v1/statuses_controller_spec.rb

@@ -0,0 +1,173 @@
+require 'rails_helper'
+
+RSpec.describe Api::V1::StatusesController, type: :controller do
+  render_views
+
+  let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
+  let(:token) { double acceptable?: true, resource_owner_id: user.id }
+
+  before do
+    stub_request(:post, "https://pubsubhubbub.superfeedr.com/").to_return(:status => 200, :body => "", :headers => {})
+    allow(controller).to receive(:doorkeeper_token) { token }
+  end
+
+  describe 'GET #show' do
+    let(:status) { Fabricate(:status, account: user.account) }
+
+    it 'returns http success' do
+      get :show, params: { id: status.id }
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'GET #context' do
+    let(:status) { Fabricate(:status, account: user.account) }
+
+    before do
+      Fabricate(:status, account: user.account, thread: status)
+    end
+
+    it 'returns http success' do
+      get :context, params: { id: status.id }
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'GET #home' do
+    it 'returns http success' do
+      get :home
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'GET #mentions' do
+    it 'returns http success' do
+      get :mentions
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'POST #create' do
+    before do
+      post :create, params: { status: 'Hello world' }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+  end
+
+  describe 'DELETE #destroy' do
+    let(:status) { Fabricate(:status, account: user.account) }
+
+    before do
+      post :destroy, params: { id: status.id }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'removes the status' do
+      expect(Status.find_by(id: status.id)).to be nil
+    end
+  end
+
+  describe 'POST #reblog' do
+    let(:status) { Fabricate(:status, account: user.account) }
+
+    before do
+      post :reblog, params: { id: status.id }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'updates the reblogs count' do
+      expect(status.reblogs_count).to eq 1
+    end
+
+    it 'updates the reblogged attribute' do
+      expect(user.account.reblogged?(status)).to be true
+    end
+
+    it 'return json with updated attributes' do
+      hash_body = body_as_json
+
+      expect(hash_body[:reblog][:id]).to eq status.id
+      expect(hash_body[:reblog][:reblogs_count]).to eq 1
+      expect(hash_body[:reblog][:reblogged]).to be true
+    end
+  end
+
+  describe 'POST #unreblog' do
+    let(:status) { Fabricate(:status, account: user.account) }
+
+    before do
+      post :reblog,   params: { id: status.id }
+      post :unreblog, params: { id: status.id }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'updates the reblogs count' do
+      expect(status.reblogs_count).to eq 0
+    end
+
+    it 'updates the reblogged attribute' do
+      expect(user.account.reblogged?(status)).to be false
+    end
+  end
+
+  describe 'POST #favourite' do
+    let(:status) { Fabricate(:status, account: user.account) }
+
+    before do
+      post :favourite, params: { id: status.id }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'updates the favourites count' do
+      expect(status.favourites_count).to eq 1
+    end
+
+    it 'updates the favourited attribute' do
+      expect(user.account.favourited?(status)).to be true
+    end
+
+    it 'return json with updated attributes' do
+      hash_body = body_as_json
+
+      expect(hash_body[:id]).to eq status.id
+      expect(hash_body[:favourites_count]).to eq 1
+      expect(hash_body[:favourited]).to be true
+    end
+  end
+
+  describe 'POST #unfavourite' do
+    let(:status) { Fabricate(:status, account: user.account) }
+
+    before do
+      post :favourite,   params: { id: status.id }
+      post :unfavourite, params: { id: status.id }
+    end
+
+    it 'returns http success' do
+      expect(response).to have_http_status(:success)
+    end
+
+    it 'updates the favourites count' do
+      expect(status.favourites_count).to eq 0
+    end
+
+    it 'updates the favourited attribute' do
+      expect(user.account.favourited?(status)).to be false
+    end
+  end
+end