Refactored generation of unique tags, URIs and object URLs into own classes,

as well as formatting of content

spec/lib/feed_manager_spec.rb

@@ -0,0 +1,23 @@
+require 'rails_helper'
+
+RSpec.describe FeedManager do
+  describe '#key' do
+    subject { FeedManager.instance.key(:home, 1) }
+
+    it 'returns a string' do
+      expect(subject).to be_a String
+    end
+  end
+
+  describe '#filter_status?' do
+    let(:followee) { Fabricate(:account, username: 'alice') }
+    let(:status)   { Fabricate(:status, text: 'Hello world', account: followee) }
+    let(:follower) { Fabricate(:account, username: 'bob') }
+
+    subject { FeedManager.instance.filter_status?(status, follower) }
+
+    it 'returns a boolean value' do
+      expect(subject).to be false
+    end
+  end
+end

spec/lib/formatter_spec.rb

@@ -0,0 +1,39 @@
+require 'rails_helper'
+
+RSpec.describe Formatter do
+  let(:account)       { Fabricate(:account, username: 'alice') }
+  let(:local_status)  { Fabricate(:status, text: 'Hello world http://google.com', account: account) }
+  let(:remote_status) { Fabricate(:status, text: '<script>alert("Hello")</script> Beep boop', uri: 'beepboop', account: account) }
+
+  describe '#format' do
+    subject { Formatter.instance.format(local_status) }
+
+    it 'returns a string' do
+      expect(subject).to be_a String
+    end
+
+    it 'contains plain text' do
+      expect(subject).to match('Hello world')
+    end
+
+    it 'contains a link' do
+      expect(subject).to match('<a rel="nofollow noopener" href="http://google.com">http://google.com</a>')
+    end
+  end
+
+  describe '#reformat' do
+    subject { Formatter.instance.format(remote_status) }
+
+    it 'returns a string' do
+      expect(subject).to be_a String
+    end
+
+    it 'contains plain text' do
+      expect(subject).to match('Beep boop')
+    end
+
+    it 'does not contain scripts' do
+      expect(subject).to_not match('<script>alert("Hello")</script>')
+    end
+  end
+end

spec/lib/tag_manager_spec.rb

@@ -0,0 +1,107 @@
+require 'rails_helper'
+
+RSpec.describe TagManager do
+  let(:local_domain) { Rails.configuration.x.local_domain }
+
+  describe '#unique_tag' do
+    it 'returns a string' do
+      expect(TagManager.instance.unique_tag(Time.now, 12, 'Status')).to be_a String
+    end
+  end
+
+  describe '#unique_tag_to_local_id' do
+    it 'returns the ID part' do
+      expect(TagManager.instance.unique_tag_to_local_id("tag:#{local_domain};objectId=12:objectType=Status", 'Status')).to eql '12'
+    end
+  end
+
+  describe '#local_id?' do
+    it 'returns true for a local ID' do
+      expect(TagManager.instance.local_id?("tag:#{local_domain};objectId=12:objectType=Status")).to be true
+    end
+
+    it 'returns false for a foreign ID' do
+      expect(TagManager.instance.local_id?('tag:foreign.tld;objectId=12:objectType=Status')).to be false
+    end
+  end
+
+  describe '#uri_for' do
+    let(:alice)  { Fabricate(:account, username: 'alice') }
+    let(:bob)    { Fabricate(:account, username: 'bob') }
+    let(:status) { Fabricate(:status, text: 'Hello world', account: alice) }
+
+    subject { TagManager.instance.uri_for(target) }
+
+    context 'Account' do
+      let(:target) { alice }
+
+      it 'returns a string' do
+        expect(subject).to be_a String
+      end
+    end
+
+    context 'Status' do
+      let(:target) { status }
+
+      it 'returns a string' do
+        expect(subject).to be_a String
+      end
+    end
+
+    context 'Follow' do
+      let(:target) { Fabricate(:follow, account: alice, target_account: bob) }
+
+      it 'returns a string' do
+        expect(subject).to be_a String
+      end
+    end
+
+    context 'Favourite' do
+      let(:target) { Fabricate(:favourite, account: bob, status: status) }
+
+      it 'returns a string' do
+        expect(subject).to be_a String
+      end
+    end
+  end
+
+  describe '#url_for' do
+    let(:alice)  { Fabricate(:account, username: 'alice') }
+    let(:bob)    { Fabricate(:account, username: 'bob') }
+    let(:status) { Fabricate(:status, text: 'Hello world', account: alice) }
+
+    subject { TagManager.instance.url_for(target) }
+
+    context 'Account' do
+      let(:target) { alice }
+
+      it 'returns a URL' do
+        expect(subject).to be_a String
+      end
+    end
+
+    context 'Status' do
+      let(:target) { status }
+
+      it 'returns a URL' do
+        expect(subject).to be_a String
+      end
+    end
+
+    context 'Follow' do
+      let(:target) { Fabricate(:follow, account: alice, target_account: bob) }
+
+      it 'returns a URL' do
+        expect(subject).to be_a String
+      end
+    end
+
+    context 'Favourite' do
+      let(:target) { Fabricate(:favourite, account: bob, status: status) }
+
+      it 'returns a URL' do
+        expect(subject).to be_a String
+      end
+    end
+  end
+end