Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix BootstrapTimelineService crashing when bootstrapped accounts are invalid (#12037)

Browse source 
* Add test to handle suspended and missing users in BootstrapTimelineService

* Fix BootstrapTimelineService crashing when bootstrapped accounts are invalid
This commit is contained in:
ThibG 2019-10-01 15:10:00 +02:00 • committed by Eugen Rochko
parent 541269f8bc
commit 3a4d994c40
2 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
spec/services/bootstrap_timeline_service_spec.rb
View file

@ -22,9 +22,10 @@ RSpec.describe BootstrapTimelineService, type: :service do
context 'when setting is set' do
let!(:alice) { Fabricate(:account, username: 'alice') }
let!(:bob) { Fabricate(:account, username: 'bob') }
let!(:eve) { Fabricate(:account, username: 'eve', suspended: true) }
before do
Setting.bootstrap_timeline_accounts = 'alice, bob'
Setting.bootstrap_timeline_accounts = 'alice, @bob, eve, unknown'
subject.call(source_account)
end
@ -32,6 +33,10 @@ RSpec.describe BootstrapTimelineService, type: :service do
expect(source_account.following?(alice)).to be true
expect(source_account.following?(bob)).to be true
end
it 'does not follow suspended account' do
expect(source_account.following?(eve)).to be false
end
end
end
end