Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix single Redis connection being used across all threads (#18135)

Browse source 
* Fix single Redis connection being used across all Sidekiq threads

* Fix tests
This commit is contained in:
Eugen Rochko 2022-04-28 17:47:34 +02:00 • committed by GitHub
parent 9bf04db23a
commit 3917353645
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
44 changed files with 243 additions and 124 deletions
Download patch file Download diff file Expand all files Collapse all files

18
app/lib/delivery_failure_tracker.rb
View file

@ -1,6 +1,8 @@
# frozen_string_literal: true
class DeliveryFailureTracker
include Redisable
FAILURE_DAYS_THRESHOLD = 7
def initialize(url_or_host)
@ -8,21 +10,21 @@ class DeliveryFailureTracker
end
def track_failure!
Redis.current.sadd(exhausted_deliveries_key, today)
redis.sadd(exhausted_deliveries_key, today)
UnavailableDomain.create(domain: @host) if reached_failure_threshold?
end
def track_success!
Redis.current.del(exhausted_deliveries_key)
redis.del(exhausted_deliveries_key)
UnavailableDomain.find_by(domain: @host)&.destroy
end
def clear_failures!
Redis.current.del(exhausted_deliveries_key)
redis.del(exhausted_deliveries_key)
end
def days
Redis.current.scard(exhausted_deliveries_key) || 0
redis.scard(exhausted_deliveries_key) || 0
end
def available?
@ -30,12 +32,14 @@ class DeliveryFailureTracker
end
def exhausted_deliveries_days
@exhausted_deliveries_days ||= Redis.current.smembers(exhausted_deliveries_key).sort.map { |date| Date.new(date.slice(0, 4).to_i, date.slice(4, 2).to_i, date.slice(6, 2).to_i) }
@exhausted_deliveries_days ||= redis.smembers(exhausted_deliveries_key).sort.map { |date| Date.new(date.slice(0, 4).to_i, date.slice(4, 2).to_i, date.slice(6, 2).to_i) }
end
alias reset! track_success!
class << self
include Redisable
def without_unavailable(urls)
unavailable_domains_map = Rails.cache.fetch('unavailable_domains') { UnavailableDomain.pluck(:domain).index_with(true) }
@ -54,7 +58,7 @@ class DeliveryFailureTracker
end
def warning_domains
domains = Redis.current.keys(exhausted_deliveries_key_by('*')).map do |key|
domains = redis.keys(exhausted_deliveries_key_by('*')).map do |key|
key.delete_prefix(exhausted_deliveries_key_by(''))
end
@ -62,7 +66,7 @@ class DeliveryFailureTracker
end
def warning_domains_map
warning_domains.index_with { |domain| Redis.current.scard(exhausted_deliveries_key_by(domain)) }
warning_domains.index_with { |domain| redis.scard(exhausted_deliveries_key_by(domain)) }
end
private