Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix list import concurrently creating lists of the same name (#26372)

Browse source
This commit is contained in:
Claire 2023-08-07 17:59:20 +02:00 • committed by GitHub
parent cd6f2b3cbc
commit 30c64bf616
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/services/bulk_import_service.rb
View file

@ -162,10 +162,9 @@ class BulkImportService < BaseService
def import_lists!
rows = @import.rows.to_a
included_lists = rows.map { |row| row.data['list_name'] }.uniq
if @import.overwrite?
included_lists = rows.map { |row| row.data['list_name'] }.uniq
@account.owned_lists.where.not(title: included_lists).destroy_all
# As list membership changes do not retroactively change timeline
@ -175,6 +174,10 @@ class BulkImportService < BaseService
end
end
included_lists.each do |title|
@account.owned_lists.find_or_create_by!(title: title)
end
Import::RowWorker.push_bulk(rows) do |row|
[row.id]
end