Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Improve require_admin! and require_staff! filters (#7018)

Browse source 
Previously these returns 302 redirects instead of 403s, which meant posting links to admin pages in slack caused them to unfurl, rather than stay as a link. Additionally, require_admin! doesn't appear to be actively used, on require_staff!
This commit is contained in:
Emelia Smith 2018-04-03 13:07:32 +02:00 • committed by Eugen Rochko
parent 1c293086a1
commit 2e59751823
3 changed files with 58 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

25
spec/controllers/admin/base_controller_spec.rb
View file

@ -9,18 +9,25 @@ describe Admin::BaseController, type: :controller do
end
end
it 'renders admin layout' do
it 'requires administrator or moderator' do
routes.draw { get 'success' => 'admin/base#success' }
sign_in(Fabricate(:user, admin: false, moderator: false))
get :success
expect(response).to have_http_status(:forbidden)
end
it 'renders admin layout as a moderator' do
routes.draw { get 'success' => 'admin/base#success' }
sign_in(Fabricate(:user, moderator: true))
get :success
expect(response).to render_template layout: 'admin'
end
it 'renders admin layout as an admin' do
routes.draw { get 'success' => 'admin/base#success' }
sign_in(Fabricate(:user, admin: true))
get :success
expect(response).to render_template layout: 'admin'
end
it 'requires administrator' do
routes.draw { get 'success' => 'admin/base#success' }
sign_in(Fabricate(:user, admin: false))
get :success
expect(response).to redirect_to('/')
end
end