Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Improve require_admin! and require_staff! filters (#7018)

Browse source 
Previously these returns 302 redirects instead of 403s, which meant posting links to admin pages in slack caused them to unfurl, rather than stay as a link. Additionally, require_admin! doesn't appear to be actively used, on require_staff!
This commit is contained in:
Emelia Smith 2018-04-03 13:07:32 +02:00 • committed by Eugen Rochko
parent 1c293086a1
commit 2e59751823
3 changed files with 58 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/application_controller.rb
View file

@ -39,11 +39,11 @@ class ApplicationController < ActionController::Base
end
def require_admin!
redirect_to root_path unless current_user&.admin?
forbidden unless current_user&.admin?
end
def require_staff!
redirect_to root_path unless current_user&.staff?
forbidden unless current_user&.staff?
end
def check_suspension