Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix UniqueUsernameValidator comparison (#6926)

Browse source 
Comparison was downcasing only one side, therefore if previously
existing account had a non-lowercase spelling, it would be ignored
when checking for duplicates.

New rake task `mastodon:maintenance:find_duplicate_usernames` will
help find constraint violations that might have occured from the
presence of this bug.

Bump version to 2.3.3
This commit is contained in:
Eugen Rochko 2018-03-27 04:33:57 +02:00 • committed by GitHub
parent 40e5d2303b
commit 2a90da1837
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/validators/unique_username_validator.rb
View file

@ -6,7 +6,7 @@ class UniqueUsernameValidator < ActiveModel::Validator
normalized_username = account.username.downcase.delete('.')
scope = Account.where(domain: nil, username: normalized_username)
scope = Account.where(domain: nil).where('lower(username) = ?', normalized_username)
scope = scope.where.not(id: account.id) if account.persisted?
account.errors.add(:username, :taken) if scope.exists?