Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Punycode URI normalization (#2370)

Browse source 
* Fix #2119 - Whenever about to send a HTTP request, normalize the URI

* Add test for IDN request in FetchLinkCardService

* Perform IDN normalization on domains before they are stored in the DB
This commit is contained in:
Eugen 2017-04-25 02:47:31 +02:00 • committed by GitHub
parent bb04a9be52
commit 17c591ffba
17 changed files with 546 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/services/fetch_link_card_service.rb
View file

@ -19,7 +19,7 @@ class FetchLinkCardService < BaseService
card.title = meta_property(page, 'og:title') || page.at_xpath('//title')&.content
card.description = meta_property(page, 'og:description') || meta_property(page, 'description')
card.image = URI.parse(meta_property(page, 'og:image')) if meta_property(page, 'og:image')
card.image = URI.parse(Addressable::URI.parse(meta_property(page, 'og:image')).normalize.to_s) if meta_property(page, 'og:image')
return if card.title.blank?