Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Use "match_array" only for order independent assertions (#3626)

Browse source
This commit is contained in:
unarist 2017-06-08 01:59:28 +09:00 • committed by Matt Jankowski
parent d3bbef27e7
commit 0f1b1d78b1
4 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
spec/controllers/application_controller_spec.rb
View file

@ -266,7 +266,7 @@ describe ApplicationController, type: :controller do
shared_examples 'receives :with_includes' do |fabricator, klass|
it 'uses raw if it is not an ActiveRecord::Relation' do
record = Fabricate(fabricator)
expect(C.new.cache_collection([record], klass)).to match_array([record])
expect(C.new.cache_collection([record], klass)).to eq [record]
end
end
@ -277,7 +277,7 @@ describe ApplicationController, type: :controller do
record = Fabricate(fabricator)
relation = klass.none
allow(relation).to receive(:cache_ids).and_return([record])
expect(C.new.cache_collection(relation, klass)).to match_array([record])
expect(C.new.cache_collection(relation, klass)).to eq [record]
end
end

2
spec/controllers/statuses_controller_spec.rb
View file

@ -61,7 +61,7 @@ describe StatusesController do
get :show, params: { account_username: status.account.username, id: status.id }
expect(assigns(:ancestors)).to match_array([ancestor])
expect(assigns(:ancestors)).to eq [ancestor]
end
it 'assigns @ancestors for [] if it is not a reply' do

4
spec/controllers/stream_entries_controller_spec.rb
View file

@ -73,8 +73,8 @@ RSpec.describe StreamEntriesController, type: :controller do
get :show, params: { account_username: status.account.username, id: status.stream_entry.id }
expect(assigns(:ancestors)).to match_array([ancestor])
expect(assigns(:descendants)).to match_array([descendant])
expect(assigns(:ancestors)).to eq [ancestor]
expect(assigns(:descendants)).to eq [descendant]
expect(response).to have_http_status(:success)
end