Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Add account_id param to GET /api/v1/notifications (#10796)

Browse source 
* Add `from_account` to notifications API

this adds the ability to filter notifications by the account they
originated from

* passing a non-existent user should cause none to be returned

* Fix codeclimate warnings

* fix more codeclimate warnings

* make requested changes:

* use account id instead of user@domain
* name the param `account_id` instead of `from_account`

* Don't use `return` in a lambda
This commit is contained in:
Paul Woolcock 2019-05-21 07:28:49 -04:00 • committed by Eugen Rochko
parent 4d65740663
commit 0c933c1b8c
3 changed files with 77 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/controllers/api/v1/notifications_controller.rb
View file

@ -44,7 +44,7 @@ class Api::V1::NotificationsController < Api::BaseController
end
def browserable_account_notifications
current_account.notifications.browserable(exclude_types)
current_account.notifications.browserable(exclude_types, from_account)
end
def target_statuses_from_notifications
@ -81,6 +81,10 @@ class Api::V1::NotificationsController < Api::BaseController
val
end
def from_account
params[:account_id]
end
def pagination_params(core_params)
params.slice(:limit, :exclude_types).permit(:limit, exclude_types: []).merge(core_params)
end