Fix processing of remote Delete activities (#16084)
* Add tests * Ensure deleted statuses are marked as such * Save some redis memory by not storing URIs in delete_upon_arrival values * Avoid possible race condition when processing incoming Deletes * Avoid potential duplicate Delete forwards * Lower lock durations to reduce issues in case of hard crash of the Rails process * Check for `lock.aquired?` and improve comment * Refactor RedisLock usage in app/lib/activitypub * Fix using incorrect or non-existent sender for relaying Deletes
This commit is contained in:
parent
2c322addf3
commit
0b36e3419d
6 changed files with 94 additions and 82 deletions
|
@ -49,4 +49,24 @@ RSpec.describe ActivityPub::Activity::Delete do
|
|||
end
|
||||
end
|
||||
end
|
||||
|
||||
context 'when the status has been reported' do
|
||||
describe '#perform' do
|
||||
subject { described_class.new(json, sender) }
|
||||
let!(:reporter) { Fabricate(:account) }
|
||||
|
||||
before do
|
||||
reporter.reports.create!(target_account: status.account, status_ids: [status.id], forwarded: false)
|
||||
subject.perform
|
||||
end
|
||||
|
||||
it 'marks the status as deleted' do
|
||||
expect(Status.find_by(id: status.id)).to be_nil
|
||||
end
|
||||
|
||||
it 'actually keeps a copy for inspection' do
|
||||
expect(Status.with_discarded.find_by(id: status.id)).to_not be_nil
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue