Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Rename admin/accounts_helper to admin/filter_helper (#1816)

Browse source 
- Add some spec coverage for both methods
- Add explicit constant call-outs for where the params are from
This commit is contained in:
Matt Jankowski 2017-04-14 21:09:55 -04:00 • committed by Eugen
parent 08059ddda9
commit 09540192c9
3 changed files with 29 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

13
app/helpers/admin/accounts_helper.rb → app/helpers/admin/filter_helper.rb
View file

@ -1,9 +1,10 @@
# frozen_string_literal: true
module Admin::AccountsHelper
def filter_params(more_params)
params.permit(:local, :remote, :by_domain, :silenced, :suspended, :recent, :resolved).merge(more_params)
end
module Admin::FilterHelper
ACCOUNT_FILTERS = %i[local remote by_domain silenced suspended recent].freeze
REPORT_FILTERS = %i[resolved].freeze
FILTERS = ACCOUNT_FILTERS + REPORT_FILTERS
def filter_link_to(text, more_params)
new_url = filtered_url_for(more_params)
@ -16,6 +17,10 @@ module Admin::AccountsHelper
private
def filter_params(more_params)
params.permit(FILTERS).merge(more_params)
end
def filter_link_class(new_url)
filtered_url_for(params) == new_url ? 'selected' : ''
end