Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix scheduled toot with media immediately creating a toot (#9894)

Browse source 
* Add test for not persisting status when attaching media to scheduled toot

* Prevent status used for validation from being persisted to the database

Fixes #9893

Thanks to tateisu for the help investigating this.
This commit is contained in:
ThibG 2019-01-21 20:03:04 +01:00 • committed by Eugen Rochko
parent dd8a00a3cc
commit 061feb63ed
2 changed files with 18 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
spec/services/post_status_service_spec.rb
View file

@ -36,6 +36,20 @@ RSpec.describe PostStatusService, type: :service do
expect(status.params['text']).to eq 'Hi future!'
end
it 'does not immediately create a status when scheduling a status' do
account = Fabricate(:account)
media = Fabricate(:media_attachment)
future = Time.now.utc + 2.hours
status = subject.call(account, text: 'Hi future!', media_ids: [media.id], scheduled_at: future)
expect(status).to be_a ScheduledStatus
expect(status.scheduled_at).to eq future
expect(status.params['text']).to eq 'Hi future!'
expect(media.reload.status).to be_nil
expect(Status.where(text: 'Hi future!').exists?).to be_falsey
end
it 'creates response to the original status of boost' do
boosted_status = Fabricate(:status)
in_reply_to_status = Fabricate(:status, reblog: boosted_status)