Unfloyded/Legamunt
0
0
Fork 0
Code Activity

Fix Sidekiq warnings about JSON serialization (#17381)

Browse source 
* Fix Sidekiq warnings about JSON serialization

This occurs on every symbol argument we pass, and every symbol key in hashes,
because Sidekiq expects strings instead.

See https://github.com/mperham/sidekiq/pull/5071

We do not need to change how workers parse their arguments because this has
not changed and we were already converting to symbols adequately or using
`with_indifferent_access`.

* Set Sidekiq to raise on unsafe arguments in test mode

In order to more easily catch issues that would produce warnings in production
code.
This commit is contained in:
Claire 2022-01-28 00:43:56 +01:00 • committed by GitHub
parent 14c69a535b
commit 03d59340da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 25 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/models/admin/status_batch_action.rb
View file

@ -56,7 +56,7 @@ class Admin::StatusBatchAction
end
UserMailer.warning(target_account.user, @warning).deliver_later! if target_account.local?
RemovalWorker.push_bulk(status_ids) { |status_id| [status_id, preserve: target_account.local?, immediate: !target_account.local?] }
RemovalWorker.push_bulk(status_ids) { |status_id| [status_id, { 'preserve' => target_account.local?, 'immediate' => !target_account.local? }] }
end
def handle_report!