e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
145 lines
3.7 KiB
Ruby
145 lines
3.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe FollowingAccountsController do
|
|
render_views
|
|
|
|
let(:alice) { Fabricate(:account) }
|
|
let(:followee0) { Fabricate(:account) }
|
|
let(:followee1) { Fabricate(:account) }
|
|
|
|
describe 'GET #index' do
|
|
let!(:follow0) { alice.follow!(followee0) }
|
|
let!(:follow1) { alice.follow!(followee1) }
|
|
|
|
context 'when format is html' do
|
|
subject(:response) { get :index, params: { account_username: alice.username, format: :html } }
|
|
|
|
context 'when account is permanently suspended' do
|
|
before do
|
|
alice.suspend!
|
|
alice.deletion_request.destroy
|
|
end
|
|
|
|
it 'returns http gone' do
|
|
expect(response).to have_http_status(410)
|
|
end
|
|
end
|
|
|
|
context 'when account is temporarily suspended' do
|
|
before do
|
|
alice.suspend!
|
|
end
|
|
|
|
it 'returns http forbidden' do
|
|
expect(response).to have_http_status(403)
|
|
end
|
|
end
|
|
|
|
it 'assigns follows' do
|
|
expect(response).to have_http_status(200)
|
|
|
|
assigned = assigns(:follows).to_a
|
|
expect(assigned.size).to eq 2
|
|
expect(assigned[0]).to eq follow1
|
|
expect(assigned[1]).to eq follow0
|
|
end
|
|
|
|
it 'does not assign blocked users' do
|
|
user = Fabricate(:user)
|
|
user.account.block!(followee0)
|
|
sign_in(user)
|
|
|
|
expect(response).to have_http_status(200)
|
|
|
|
assigned = assigns(:follows).to_a
|
|
expect(assigned.size).to eq 1
|
|
expect(assigned[0]).to eq follow1
|
|
end
|
|
end
|
|
|
|
context 'when format is json' do
|
|
subject(:response) { get :index, params: { account_username: alice.username, page: page, format: :json } }
|
|
subject(:body) { JSON.parse(response.body) }
|
|
|
|
context 'with page' do
|
|
let(:page) { 1 }
|
|
|
|
it 'returns followers' do
|
|
expect(response).to have_http_status(200)
|
|
expect(body['totalItems']).to eq 2
|
|
expect(body['partOf']).to be_present
|
|
end
|
|
|
|
context 'when account is permanently suspended' do
|
|
before do
|
|
alice.suspend!
|
|
alice.deletion_request.destroy
|
|
end
|
|
|
|
it 'returns http gone' do
|
|
expect(response).to have_http_status(410)
|
|
end
|
|
end
|
|
|
|
context 'when account is temporarily suspended' do
|
|
before do
|
|
alice.suspend!
|
|
end
|
|
|
|
it 'returns http forbidden' do
|
|
expect(response).to have_http_status(403)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'without page' do
|
|
let(:page) { nil }
|
|
|
|
it 'returns followers' do
|
|
expect(response).to have_http_status(200)
|
|
expect(body['totalItems']).to eq 2
|
|
expect(body['partOf']).to be_blank
|
|
end
|
|
|
|
context 'when account hides their network' do
|
|
before do
|
|
alice.user.settings.hide_network = true
|
|
end
|
|
|
|
it 'returns followers count' do
|
|
expect(body['totalItems']).to eq 2
|
|
end
|
|
|
|
it 'does not return items' do
|
|
expect(body['items']).to be_blank
|
|
expect(body['orderedItems']).to be_blank
|
|
expect(body['first']).to be_blank
|
|
expect(body['last']).to be_blank
|
|
end
|
|
end
|
|
|
|
context 'when account is permanently suspended' do
|
|
before do
|
|
alice.suspend!
|
|
alice.deletion_request.destroy
|
|
end
|
|
|
|
it 'returns http gone' do
|
|
expect(response).to have_http_status(410)
|
|
end
|
|
end
|
|
|
|
context 'when account is temporarily suspended' do
|
|
before do
|
|
alice.suspend!
|
|
end
|
|
|
|
it 'returns http forbidden' do
|
|
expect(response).to have_http_status(403)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|