SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Fix preview card player getting embedded when clicking on the external link button (#29457)

Browse Source
This commit is contained in:
Claire 2024-02-29 14:54:02 +01:00 committed by GitHub
parent 6675bf574a
commit f24c62a5c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/javascript/mastodon/features/status/components/card.jsx
View File

@ -92,6 +92,10 @@ export default class Card extends PureComponent {
this.setState({ embedded: true }); this.setState({ embedded: true });
}; };
handleExternalLinkClick = (e) => {
e.stopPropagation();
};
setRef = c => { setRef = c => {
this.node = c; this.node = c;
}; };
@ -201,7 +205,7 @@ export default class Card extends PureComponent {
<div className='status-card__actions' onClick={this.handleEmbedClick} role='none'> <div className='status-card__actions' onClick={this.handleEmbedClick} role='none'>
<div> <div>
<button type='button' onClick={this.handleEmbedClick}><Icon id='play' icon={PlayArrowIcon} /></button> <button type='button' onClick={this.handleEmbedClick}><Icon id='play' icon={PlayArrowIcon} /></button>
<a href={card.get('url')} target='_blank' rel='noopener noreferrer'><Icon id='external-link' icon={OpenInNewIcon} /></a> <a href={card.get('url')} onClick={this.handleExternalLinkClick} target='_blank' rel='noopener noreferrer'><Icon id='external-link' icon={OpenInNewIcon} /></a>
</div> </div>
</div> </div>
) : spoilerButton} ) : spoilerButton}