SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Simplify model validation specs for PreviewCard (#32469)

Browse Source
This commit is contained in:
Matt Jankowski 2024-10-25 03:55:33 -04:00 committed by GitHub
parent 37bcbeab4a
commit e5be4bf8d8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
spec/models/preview_card_spec.rb
View File

@ -9,26 +9,10 @@ RSpec.describe PreviewCard do
end
end
describe 'validations' do
describe 'urls' do
it 'allows http schemes' do
record = described_class.new(url: 'http://example.host/path')
expect(record).to be_valid
end
it 'allows https schemes' do
record = described_class.new(url: 'https://example.host/path')
expect(record).to be_valid
end
it 'does not allow javascript: schemes' do
record = described_class.new(url: 'javascript:alert()')
expect(record).to_not be_valid
expect(record).to model_have_error_on_field(:url)
end
describe 'Validations' do
describe 'url' do
it { is_expected.to allow_values('http://example.host/path', 'https://example.host/path').for(:url) }
it { is_expected.to_not allow_value('javascript:alert()').for(:url) }
end
end
end