SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Fix POST /api/v1/admin/domain_allows returning 200 when no domain is specified (#24958)

Browse Source
This commit is contained in:
Daniel M Brasil 2023-05-22 08:44:49 -03:00 committed by GitHub
parent e328ab7e5a
commit ce8b5899ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/api/v1/admin/domain_allows_controller.rb
View File

@ -29,7 +29,7 @@ class Api::V1::Admin::DomainAllowsController < Api::BaseController
def create
authorize :domain_allow, :create?
@domain_allow = DomainAllow.find_by(resource_params)
@domain_allow = DomainAllow.find_by(domain: resource_params[:domain])
if @domain_allow.nil?
@domain_allow = DomainAllow.create!(resource_params)

8
spec/controllers/api/v1/admin/domain_allows_controller_spec.rb
View File

@ -128,5 +128,13 @@ RSpec.describe Api::V1::Admin::DomainAllowsController do
expect(response).to have_http_status(422)
end
end
context 'when domain name is not specified' do
it 'returns http unprocessable entity' do
post :create
expect(response).to have_http_status(422)
end
end
end
end