SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Fix selectSettingsNotificationsExcludedTypes not being memoized properly (#31881)

Browse Source
This commit is contained in:
Claire 2024-09-16 16:51:56 +02:00 committed by GitHub
parent 6c76a7a907
commit ca8e892c1a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/javascript/mastodon/selectors/settings.ts
View File

@ -1,17 +1,27 @@
import { createSelector } from '@reduxjs/toolkit';
import type { RootState } from 'mastodon/store';
/* eslint-disable @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access */
// state.settings is not yet typed, so we disable some ESLint checks for those selectors
export const selectSettingsNotificationsShows = (state: RootState) =>
state.settings.getIn(['notifications', 'shows']).toJS() as Record<
export const selectSettingsNotificationsShows = createSelector(
[
(state) =>
state.settings.getIn(['notifications', 'shows']) as Immutable.Map<
string,
boolean
>;
>,
],
(shows) => shows.toJS() as Record<string, boolean>,
);
export const selectSettingsNotificationsExcludedTypes = (state: RootState) =>
Object.entries(selectSettingsNotificationsShows(state))
export const selectSettingsNotificationsExcludedTypes = createSelector(
[selectSettingsNotificationsShows],
(shows) =>
Object.entries(shows)
.filter(([_type, enabled]) => !enabled)
.map(([type, _enabled]) => type);
.map(([type, _enabled]) => type),
);
export const selectSettingsNotificationsQuickFilterShow = (state: RootState) =>
state.settings.getIn(['notifications', 'quickFilter', 'show']) as boolean;