SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Change Report category to "violation" if rule IDs are provided (#20137)

Browse Source 
* Change Report category to "violation" if rule IDs are provided

* Fix LiteralAsCondition

* Add parentheses to conditional statement
This commit is contained in:
trwnh 2022-11-08 10:28:02 -06:00 committed by GitHub
parent c476dfc725
commit b1a48e05b6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/services/report_service.rb
View File

@ -8,7 +8,7 @@ class ReportService < BaseService
@target_account = target_account @target_account = target_account
@status_ids = options.delete(:status_ids).presence || [] @status_ids = options.delete(:status_ids).presence || []
@comment = options.delete(:comment).presence || '' @comment = options.delete(:comment).presence || ''
@category = options.delete(:category).presence || 'other' @category = options[:rule_ids].present? ? 'violation' : (options.delete(:category).presence || 'other')
@rule_ids = options.delete(:rule_ids).presence @rule_ids = options.delete(:rule_ids).presence
@options = options @options = options