SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Fix off-by-one error in aria-posinset (#8388)

Browse Source 
Fix #8191
This commit is contained in:
Eugen Rochko 2018-08-23 18:28:59 +02:00 committed by GitHub
parent 66dbb59aa1
commit 885711afb9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/javascript/mastodon/components/intersection_observer_article.js
View File

@ -109,7 +109,7 @@ export default class IntersectionObserverArticle extends React.Component {
return ( return (
<article <article
ref={this.handleRef} ref={this.handleRef}
aria-posinset={index} aria-posinset={index + 1}
aria-setsize={listLength} aria-setsize={listLength}
style={{ height: `${this.height || cachedHeight}px`, opacity: 0, overflow: 'hidden' }} style={{ height: `${this.height || cachedHeight}px`, opacity: 0, overflow: 'hidden' }}
data-id={id} data-id={id}
@ -121,7 +121,7 @@ export default class IntersectionObserverArticle extends React.Component {
} }
return ( return (
<article ref={this.handleRef} aria-posinset={index} aria-setsize={listLength} data-id={id} tabIndex='0'> <article ref={this.handleRef} aria-posinset={index + 1} aria-setsize={listLength} data-id={id} tabIndex='0'>
{children && React.cloneElement(children, { hidden: false })} {children && React.cloneElement(children, { hidden: false })}
</article> </article>
); );