SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Reduce factories (36 > 12) in AccountReachFinder spec (#32482)

Browse Source
This commit is contained in:
Matt Jankowski 2024-10-15 09:18:57 -04:00 committed by GitHub
parent 92bb19773a
commit 6a39212b02
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
spec/lib/account_reach_finder_spec.rb
View File

@ -38,16 +38,23 @@ RSpec.describe AccountReachFinder do
end end
describe '#inboxes' do describe '#inboxes' do
it 'includes the preferred inbox URL of followers' do subject { described_class.new(account).inboxes }
expect(described_class.new(account).inboxes).to include(*[ap_follower_example_com, ap_follower_example_org, ap_follower_with_shared].map(&:preferred_inbox_url))
it 'includes the preferred inbox URL of followers and recently mentioned accounts but not unrelated users' do
expect(subject)
.to include(*follower_inbox_urls)
.and include(*mentioned_account_inbox_urls)
.and not_include(unrelated_account.preferred_inbox_url)
end end
it 'includes the preferred inbox URL of recently-mentioned accounts' do def follower_inbox_urls
expect(described_class.new(account).inboxes).to include(*[ap_mentioned_with_shared, ap_mentioned_example_com, ap_mentioned_example_org].map(&:preferred_inbox_url)) [ap_follower_example_com, ap_follower_example_org, ap_follower_with_shared]
.map(&:preferred_inbox_url)
end end
it 'does not include the inbox of unrelated users' do def mentioned_account_inbox_urls
expect(described_class.new(account).inboxes).to_not include(unrelated_account.preferred_inbox_url) [ap_mentioned_with_shared, ap_mentioned_example_com, ap_mentioned_example_org]
.map(&:preferred_inbox_url)
end end
end end
end end