SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Simplify model validation specs for AccountMigration (#32494)

Browse Source
This commit is contained in:
Matt Jankowski 2024-10-25 04:02:13 -04:00 committed by GitHub
parent 86132f7dd3
commit 15f6336cdd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
spec/models/account_migration_spec.rb
View File

@ -9,8 +9,8 @@ RSpec.describe AccountMigration do
end
end
describe 'validations' do
subject { described_class.new(account: source_account, acct: target_acct) }
describe 'Validations' do
subject { Fabricate.build :account_migration, account: source_account }
let(:source_account) { Fabricate(:account) }
let(:target_acct) { target_account.acct }
@ -26,9 +26,7 @@ RSpec.describe AccountMigration do
allow(service_double).to receive(:call).with(target_acct, anything).and_return(target_account)
end
it 'passes validations' do
expect(subject).to be_valid
end
it { is_expected.to allow_value(target_account.acct).for(:acct) }
end
context 'with unresolvable account' do
@ -40,17 +38,13 @@ RSpec.describe AccountMigration do
allow(service_double).to receive(:call).with(target_acct, anything).and_return(nil)
end
it 'has errors on acct field' do
expect(subject).to model_have_error_on_field(:acct)
end
it { is_expected.to_not allow_value(target_acct).for(:acct) }
end
context 'with a space in the domain part' do
let(:target_acct) { 'target@remote. org' }
it 'has errors on acct field' do
expect(subject).to model_have_error_on_field(:acct)
end
it { is_expected.to_not allow_value(target_acct).for(:acct) }
end
end
end