SWREI/instrumental
0
0
Fork 0
Code Issues Activity

Remove single-use shared examples in controller specs (#32044)

Browse Source
This commit is contained in:
Matt Jankowski 2024-09-25 03:50:15 -04:00 committed by GitHub
parent 69aa5699ce
commit 06ecf9008b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/controllers/settings/featured_tags_controller_spec.rb
View File

@ -5,16 +5,10 @@ require 'rails_helper'
RSpec.describe Settings::FeaturedTagsController do
render_views
shared_examples 'authenticate user' do
it 'redirects to sign_in page' do
expect(subject).to redirect_to new_user_session_path
end
end
context 'when user is not signed in' do
subject { post :create }
it_behaves_like 'authenticate user'
it { is_expected.to redirect_to new_user_session_path }
end
context 'when user is signed in' do

10
spec/controllers/settings/migrations_controller_spec.rb
View File

@ -5,17 +5,11 @@ require 'rails_helper'
RSpec.describe Settings::MigrationsController do
render_views
shared_examples 'authenticate user' do
it 'redirects to sign_in page' do
expect(subject).to redirect_to new_user_session_path
end
end
describe 'GET #show' do
context 'when user is not sign in' do
subject { get :show }
it_behaves_like 'authenticate user'
it { is_expected.to redirect_to new_user_session_path }
end
context 'when user is sign in' do
@ -49,7 +43,7 @@ RSpec.describe Settings::MigrationsController do
context 'when user is not sign in' do
subject { post :create }
it_behaves_like 'authenticate user'
it { is_expected.to redirect_to new_user_session_path }
end
context 'when user is signed in' do