2023-02-22 09:55:31 +09:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2016-02-23 00:00:20 +09:00
|
|
|
require 'rails_helper'
|
2017-04-15 20:26:03 +09:00
|
|
|
require 'devise_two_factor/spec_helpers'
|
2016-02-23 00:00:20 +09:00
|
|
|
|
2023-05-04 12:49:53 +09:00
|
|
|
RSpec.describe User do
|
2023-02-19 07:17:59 +09:00
|
|
|
let(:password) { 'abcd1234' }
|
|
|
|
let(:account) { Fabricate(:account, username: 'alice') }
|
|
|
|
|
2017-04-15 20:26:03 +09:00
|
|
|
it_behaves_like 'two_factor_backupable'
|
|
|
|
|
2017-05-30 22:28:56 +09:00
|
|
|
describe 'otp_secret' do
|
|
|
|
it 'is encrypted with OTP_SECRET environment variable' do
|
|
|
|
user = Fabricate(:user,
|
|
|
|
encrypted_otp_secret: "Fttsy7QAa0edaDfdfSz094rRLAxc8cJweDQ4BsWH/zozcdVA8o9GLqcKhn2b\nGi/V\n",
|
|
|
|
encrypted_otp_secret_iv: 'rys3THICkr60BoWC',
|
|
|
|
encrypted_otp_secret_salt: '_LMkAGvdg7a+sDIKjI3mR2Q==')
|
|
|
|
|
|
|
|
expect(user.otp_secret).to eq 'anotpsecretthatshouldbeencrypted'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-04-05 07:29:56 +09:00
|
|
|
describe 'validations' do
|
|
|
|
it 'is invalid without an account' do
|
|
|
|
user = Fabricate.build(:user, account: nil)
|
|
|
|
user.valid?
|
|
|
|
expect(user).to model_have_error_on_field(:account)
|
|
|
|
end
|
2016-02-25 08:17:01 +09:00
|
|
|
|
2017-04-05 07:29:56 +09:00
|
|
|
it 'is invalid without a valid email' do
|
|
|
|
user = Fabricate.build(:user, email: 'john@')
|
|
|
|
user.valid?
|
|
|
|
expect(user).to model_have_error_on_field(:email)
|
|
|
|
end
|
2017-05-08 10:32:52 +09:00
|
|
|
|
2017-06-08 22:22:01 +09:00
|
|
|
it 'is valid with an invalid e-mail that has already been saved' do
|
|
|
|
user = Fabricate.build(:user, email: 'invalid-email')
|
|
|
|
user.save(validate: false)
|
|
|
|
expect(user.valid?).to be true
|
|
|
|
end
|
|
|
|
|
2023-11-22 20:38:07 +09:00
|
|
|
it 'cleans out invalid locale' do
|
|
|
|
user = Fabricate.build(:user, locale: 'toto')
|
|
|
|
expect(user.valid?).to be true
|
|
|
|
expect(user.locale).to be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'cleans out invalid timezone' do
|
|
|
|
user = Fabricate.build(:user, time_zone: 'toto')
|
|
|
|
expect(user.valid?).to be true
|
|
|
|
expect(user.time_zone).to be_nil
|
|
|
|
end
|
|
|
|
|
2017-05-08 10:32:52 +09:00
|
|
|
it 'cleans out empty string from languages' do
|
2018-06-17 20:54:02 +09:00
|
|
|
user = Fabricate.build(:user, chosen_languages: [''])
|
2017-05-08 10:32:52 +09:00
|
|
|
user.valid?
|
2023-02-20 14:14:50 +09:00
|
|
|
expect(user.chosen_languages).to be_nil
|
2017-05-08 10:32:52 +09:00
|
|
|
end
|
2017-04-05 07:29:56 +09:00
|
|
|
end
|
|
|
|
|
|
|
|
describe 'scopes' do
|
|
|
|
describe 'recent' do
|
|
|
|
it 'returns an array of recent users ordered by id' do
|
|
|
|
user_1 = Fabricate(:user)
|
|
|
|
user_2 = Fabricate(:user)
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.recent).to eq [user_2, user_1]
|
2017-04-05 07:29:56 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'confirmed' do
|
|
|
|
it 'returns an array of users who are confirmed' do
|
|
|
|
user_1 = Fabricate(:user, confirmed_at: nil)
|
2018-10-08 11:50:11 +09:00
|
|
|
user_2 = Fabricate(:user, confirmed_at: Time.zone.now)
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.confirmed).to contain_exactly(user_2)
|
2017-04-05 07:29:56 +09:00
|
|
|
end
|
|
|
|
end
|
2017-05-30 22:28:56 +09:00
|
|
|
|
|
|
|
describe 'inactive' do
|
|
|
|
it 'returns a relation of inactive users' do
|
|
|
|
specified = Fabricate(:user, current_sign_in_at: 15.days.ago)
|
2018-05-05 07:54:24 +09:00
|
|
|
Fabricate(:user, current_sign_in_at: 6.days.ago)
|
2017-05-30 22:28:56 +09:00
|
|
|
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.inactive).to contain_exactly(specified)
|
2017-05-30 22:28:56 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'matches_email' do
|
|
|
|
it 'returns a relation of users whose email starts with the given string' do
|
|
|
|
specified = Fabricate(:user, email: 'specified@spec')
|
|
|
|
Fabricate(:user, email: 'unspecified@spec')
|
|
|
|
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.matches_email('specified')).to contain_exactly(specified)
|
2017-05-30 22:28:56 +09:00
|
|
|
end
|
|
|
|
end
|
2022-02-16 21:14:53 +09:00
|
|
|
|
|
|
|
describe 'matches_ip' do
|
|
|
|
it 'returns a relation of users whose ip address is matching with the given CIDR' do
|
|
|
|
user1 = Fabricate(:user)
|
|
|
|
user2 = Fabricate(:user)
|
|
|
|
Fabricate(:session_activation, user: user1, ip: '2160:2160::22', session_id: '1')
|
|
|
|
Fabricate(:session_activation, user: user1, ip: '2160:2160::23', session_id: '2')
|
|
|
|
Fabricate(:session_activation, user: user2, ip: '2160:8888::24', session_id: '3')
|
|
|
|
Fabricate(:session_activation, user: user2, ip: '2160:8888::25', session_id: '4')
|
|
|
|
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.matches_ip('2160:2160::/32')).to contain_exactly(user1)
|
2022-02-16 21:14:53 +09:00
|
|
|
end
|
|
|
|
end
|
2017-04-05 10:31:26 +09:00
|
|
|
end
|
2017-04-05 10:27:38 +09:00
|
|
|
|
2017-04-05 00:04:44 +09:00
|
|
|
describe 'blacklist' do
|
2017-04-26 08:22:51 +09:00
|
|
|
around(:each) do |example|
|
|
|
|
old_blacklist = Rails.configuration.x.email_blacklist
|
|
|
|
|
|
|
|
Rails.configuration.x.email_domains_blacklist = 'mvrht.com'
|
|
|
|
|
|
|
|
example.run
|
|
|
|
|
|
|
|
Rails.configuration.x.email_domains_blacklist = old_blacklist
|
|
|
|
end
|
|
|
|
|
2023-02-18 11:26:20 +09:00
|
|
|
it 'allows a non-blacklisted user to be created' do
|
2023-06-06 20:58:33 +09:00
|
|
|
user = described_class.new(email: 'foo@example.com', account: account, password: password, agreement: true)
|
2017-04-05 00:04:44 +09:00
|
|
|
|
2023-05-23 23:49:11 +09:00
|
|
|
expect(user).to be_valid
|
2017-04-05 00:04:44 +09:00
|
|
|
end
|
2017-04-05 10:31:26 +09:00
|
|
|
|
2023-02-18 11:26:20 +09:00
|
|
|
it 'does not allow a blacklisted user to be created' do
|
2023-06-06 20:58:33 +09:00
|
|
|
user = described_class.new(email: 'foo@mvrht.com', account: account, password: password, agreement: true)
|
2017-04-05 00:04:44 +09:00
|
|
|
|
2023-05-23 23:49:11 +09:00
|
|
|
expect(user).to_not be_valid
|
2017-04-05 00:04:44 +09:00
|
|
|
end
|
2017-04-26 08:22:51 +09:00
|
|
|
|
2023-02-18 11:26:20 +09:00
|
|
|
it 'does not allow a subdomain blacklisted user to be created' do
|
2023-06-06 20:58:33 +09:00
|
|
|
user = described_class.new(email: 'foo@mvrht.com.topdomain.tld', account: account, password: password, agreement: true)
|
2017-04-26 08:22:51 +09:00
|
|
|
|
2023-05-23 23:49:11 +09:00
|
|
|
expect(user).to_not be_valid
|
2017-04-26 08:22:51 +09:00
|
|
|
end
|
2017-04-05 00:04:44 +09:00
|
|
|
end
|
|
|
|
|
2017-04-23 11:43:42 +09:00
|
|
|
describe '#confirmed?' do
|
|
|
|
it 'returns true when a confirmed_at is set' do
|
|
|
|
user = Fabricate.build(:user, confirmed_at: Time.now.utc)
|
|
|
|
expect(user.confirmed?).to be true
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns false if a confirmed_at is nil' do
|
|
|
|
user = Fabricate.build(:user, confirmed_at: nil)
|
|
|
|
expect(user.confirmed?).to be false
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-01-05 08:15:35 +09:00
|
|
|
describe '#confirm' do
|
2023-01-25 03:40:21 +09:00
|
|
|
subject { user.confirm }
|
|
|
|
|
2023-02-20 13:24:14 +09:00
|
|
|
let(:new_email) { 'new-email@example.com' }
|
|
|
|
|
2023-01-25 03:40:21 +09:00
|
|
|
before do
|
|
|
|
allow(TriggerWebhookWorker).to receive(:perform_async)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user is already confirmed' do
|
|
|
|
let!(:user) { Fabricate(:user, confirmed_at: Time.now.utc, approved: true, unconfirmed_email: new_email) }
|
|
|
|
|
|
|
|
it 'sets email to unconfirmed_email' do
|
|
|
|
expect { subject }.to change { user.reload.email }.to(new_email)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not trigger the account.approved Web Hook' do
|
|
|
|
subject
|
2023-02-20 10:33:27 +09:00
|
|
|
expect(TriggerWebhookWorker).to_not have_received(:perform_async).with('account.approved', 'Account', user.account_id)
|
2023-01-25 03:40:21 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user is a new user' do
|
|
|
|
let(:user) { Fabricate(:user, confirmed_at: nil, unconfirmed_email: new_email) }
|
|
|
|
|
|
|
|
context 'when the user is already approved' do
|
|
|
|
around(:example) do |example|
|
|
|
|
registrations_mode = Setting.registrations_mode
|
|
|
|
Setting.registrations_mode = 'approved'
|
|
|
|
|
|
|
|
example.run
|
|
|
|
|
|
|
|
Setting.registrations_mode = registrations_mode
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
user.approve!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets email to unconfirmed_email' do
|
|
|
|
expect { subject }.to change { user.reload.email }.to(new_email)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'triggers the account.approved Web Hook' do
|
|
|
|
user.confirm
|
|
|
|
expect(TriggerWebhookWorker).to have_received(:perform_async).with('account.approved', 'Account', user.account_id).once
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user does not require explicit approval' do
|
|
|
|
around(:example) do |example|
|
|
|
|
registrations_mode = Setting.registrations_mode
|
|
|
|
Setting.registrations_mode = 'open'
|
|
|
|
|
|
|
|
example.run
|
|
|
|
|
|
|
|
Setting.registrations_mode = registrations_mode
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets email to unconfirmed_email' do
|
|
|
|
expect { subject }.to change { user.reload.email }.to(new_email)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'triggers the account.approved Web Hook' do
|
|
|
|
user.confirm
|
|
|
|
expect(TriggerWebhookWorker).to have_received(:perform_async).with('account.approved', 'Account', user.account_id).once
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user requires explicit approval but is not approved' do
|
|
|
|
around(:example) do |example|
|
|
|
|
registrations_mode = Setting.registrations_mode
|
|
|
|
Setting.registrations_mode = 'approved'
|
|
|
|
|
|
|
|
example.run
|
|
|
|
|
|
|
|
Setting.registrations_mode = registrations_mode
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'sets email to unconfirmed_email' do
|
|
|
|
expect { subject }.to change { user.reload.email }.to(new_email)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not trigger the account.approved Web Hook' do
|
|
|
|
subject
|
|
|
|
expect(TriggerWebhookWorker).to_not have_received(:perform_async).with('account.approved', 'Account', user.account_id)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#approve!' do
|
|
|
|
subject { user.approve! }
|
|
|
|
|
|
|
|
around(:example) do |example|
|
|
|
|
registrations_mode = Setting.registrations_mode
|
|
|
|
Setting.registrations_mode = 'approved'
|
|
|
|
|
|
|
|
example.run
|
|
|
|
|
|
|
|
Setting.registrations_mode = registrations_mode
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(TriggerWebhookWorker).to receive(:perform_async)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user is already confirmed' do
|
|
|
|
let(:user) { Fabricate(:user, confirmed_at: Time.now.utc, approved: false) }
|
|
|
|
|
|
|
|
it 'sets the approved flag' do
|
|
|
|
expect { subject }.to change { user.reload.approved? }.to(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'triggers the account.approved Web Hook' do
|
|
|
|
subject
|
|
|
|
expect(TriggerWebhookWorker).to have_received(:perform_async).with('account.approved', 'Account', user.account_id).once
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when the user is not confirmed' do
|
|
|
|
let(:user) { Fabricate(:user, confirmed_at: nil, approved: false) }
|
|
|
|
|
|
|
|
it 'sets the approved flag' do
|
|
|
|
expect { subject }.to change { user.reload.approved? }.to(true)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not trigger the account.approved Web Hook' do
|
|
|
|
subject
|
2023-02-20 10:33:27 +09:00
|
|
|
expect(TriggerWebhookWorker).to_not have_received(:perform_async).with('account.approved', 'Account', user.account_id)
|
2023-01-25 03:40:21 +09:00
|
|
|
end
|
2018-01-05 08:15:35 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-05-03 04:07:12 +09:00
|
|
|
describe '#disable_two_factor!' do
|
2017-05-30 22:28:56 +09:00
|
|
|
it 'saves false for otp_required_for_login' do
|
2017-05-03 04:07:12 +09:00
|
|
|
user = Fabricate.build(:user, otp_required_for_login: true)
|
|
|
|
user.disable_two_factor!
|
2017-05-30 22:28:56 +09:00
|
|
|
expect(user.reload.otp_required_for_login).to be false
|
2017-05-03 04:07:12 +09:00
|
|
|
end
|
|
|
|
|
Add WebAuthn as an alternative 2FA method (#14466)
* feat: add possibility of adding WebAuthn security keys to use as 2FA
This adds a basic UI for enabling WebAuthn 2FA. We did a little refactor
to the Settings page for editing the 2FA methods – now it will list the
methods that are available to the user (TOTP and WebAuthn) and from
there they'll be able to add or remove any of them.
Also, it's worth mentioning that for enabling WebAuthn it's required to
have TOTP enabled, so the first time that you go to the 2FA Settings
page, you'll be asked to set it up.
This work was inspired by the one donde by Github in their platform, and
despite it could be approached in different ways, we decided to go with
this one given that we feel that this gives a great UX.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: add request for WebAuthn as second factor at login if enabled
This commits adds the feature for using WebAuthn as a second factor for
login when enabled.
If users have WebAuthn enabled, now a page requesting for the use of a
WebAuthn credential for log in will appear, although a link redirecting
to the old page for logging in using a two-factor code will also be
present.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: add possibility of deleting WebAuthn Credentials
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: disable WebAuthn when an Admin disables 2FA for a user
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: remove ability to disable TOTP leaving only WebAuthn as 2FA
Following examples form other platforms like Github, we decided to make
Webauthn 2FA secondary to 2FA with TOTP, so that we removed the
possibility of removing TOTP authentication only, leaving users with
just WEbAuthn as 2FA. Instead, users will have to click on 'Disable 2FA'
in order to remove second factor auth.
The reason for WebAuthn being secondary to TOPT is that in that way,
users will still be able to log in using their code from their phone's
application if they don't have their security keys with them – or maybe
even lost them.
* We had to change a little the flow for setting up TOTP, given that now
it's possible to setting up again if you already had TOTP, in order to
let users modify their authenticator app – given that now it's not
possible for them to disable TOTP and set it up again with another
authenticator app.
So, basically, now instead of storing the new `otp_secret` in the
user, we store it in the session until the process of set up is
finished.
This was because, as it was before, when users clicked on 'Edit' in
the new two-factor methods lists page, but then went back without
finishing the flow, their `otp_secret` had been changed therefore
invalidating their previous authenticator app, making them unable to
log in again using TOTP.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* refactor: fix eslint errors
The PR build was failing given that linting returning some errors.
This commit attempts to fix them.
* refactor: normalize i18n translations
The build was failing given that i18n translations files were not
normalized.
This commits fixes that.
* refactor: avoid having the webauthn gem locked to a specific version
* refactor: use symbols for routes without '/'
* refactor: avoid sending webauthn disabled email when 2FA is disabled
When an admins disable 2FA for users, we were sending two mails
to them, one notifying that 2FA was disabled and the other to notify
that WebAuthn was disabled.
As the second one is redundant since the first email includes it, we can
remove it and send just one email to users.
* refactor: avoid creating new env variable for webauthn_origin config
* refactor: improve flash error messages for webauthn pages
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
2020-08-24 23:46:27 +09:00
|
|
|
it 'saves nil for otp_secret' do
|
|
|
|
user = Fabricate.build(:user, otp_secret: 'oldotpcode')
|
|
|
|
user.disable_two_factor!
|
2023-02-17 21:45:27 +09:00
|
|
|
expect(user.reload.otp_secret).to be_nil
|
Add WebAuthn as an alternative 2FA method (#14466)
* feat: add possibility of adding WebAuthn security keys to use as 2FA
This adds a basic UI for enabling WebAuthn 2FA. We did a little refactor
to the Settings page for editing the 2FA methods – now it will list the
methods that are available to the user (TOTP and WebAuthn) and from
there they'll be able to add or remove any of them.
Also, it's worth mentioning that for enabling WebAuthn it's required to
have TOTP enabled, so the first time that you go to the 2FA Settings
page, you'll be asked to set it up.
This work was inspired by the one donde by Github in their platform, and
despite it could be approached in different ways, we decided to go with
this one given that we feel that this gives a great UX.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: add request for WebAuthn as second factor at login if enabled
This commits adds the feature for using WebAuthn as a second factor for
login when enabled.
If users have WebAuthn enabled, now a page requesting for the use of a
WebAuthn credential for log in will appear, although a link redirecting
to the old page for logging in using a two-factor code will also be
present.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: add possibility of deleting WebAuthn Credentials
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: disable WebAuthn when an Admin disables 2FA for a user
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* feat: remove ability to disable TOTP leaving only WebAuthn as 2FA
Following examples form other platforms like Github, we decided to make
Webauthn 2FA secondary to 2FA with TOTP, so that we removed the
possibility of removing TOTP authentication only, leaving users with
just WEbAuthn as 2FA. Instead, users will have to click on 'Disable 2FA'
in order to remove second factor auth.
The reason for WebAuthn being secondary to TOPT is that in that way,
users will still be able to log in using their code from their phone's
application if they don't have their security keys with them – or maybe
even lost them.
* We had to change a little the flow for setting up TOTP, given that now
it's possible to setting up again if you already had TOTP, in order to
let users modify their authenticator app – given that now it's not
possible for them to disable TOTP and set it up again with another
authenticator app.
So, basically, now instead of storing the new `otp_secret` in the
user, we store it in the session until the process of set up is
finished.
This was because, as it was before, when users clicked on 'Edit' in
the new two-factor methods lists page, but then went back without
finishing the flow, their `otp_secret` had been changed therefore
invalidating their previous authenticator app, making them unable to
log in again using TOTP.
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
* refactor: fix eslint errors
The PR build was failing given that linting returning some errors.
This commit attempts to fix them.
* refactor: normalize i18n translations
The build was failing given that i18n translations files were not
normalized.
This commits fixes that.
* refactor: avoid having the webauthn gem locked to a specific version
* refactor: use symbols for routes without '/'
* refactor: avoid sending webauthn disabled email when 2FA is disabled
When an admins disable 2FA for users, we were sending two mails
to them, one notifying that 2FA was disabled and the other to notify
that WebAuthn was disabled.
As the second one is redundant since the first email includes it, we can
remove it and send just one email to users.
* refactor: avoid creating new env variable for webauthn_origin config
* refactor: improve flash error messages for webauthn pages
Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>
2020-08-24 23:46:27 +09:00
|
|
|
end
|
|
|
|
|
2017-05-30 22:28:56 +09:00
|
|
|
it 'saves cleared otp_backup_codes' do
|
2017-06-08 20:24:28 +09:00
|
|
|
user = Fabricate.build(:user, otp_backup_codes: %w(dummy dummy))
|
2017-05-03 04:07:12 +09:00
|
|
|
user.disable_two_factor!
|
2017-05-30 22:28:56 +09:00
|
|
|
expect(user.reload.otp_backup_codes.empty?).to be true
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#send_confirmation_instructions' do
|
|
|
|
around do |example|
|
|
|
|
queue_adapter = ActiveJob::Base.queue_adapter
|
|
|
|
example.run
|
|
|
|
ActiveJob::Base.queue_adapter = queue_adapter
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'delivers confirmation instructions later' do
|
|
|
|
user = Fabricate(:user)
|
|
|
|
ActiveJob::Base.queue_adapter = :test
|
|
|
|
|
2021-03-24 18:44:31 +09:00
|
|
|
expect { user.send_confirmation_instructions }.to have_enqueued_job(ActionMailer::MailDeliveryJob)
|
2017-05-30 22:28:56 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-11-16 00:05:20 +09:00
|
|
|
describe 'settings' do
|
2023-03-30 21:44:00 +09:00
|
|
|
it 'is instance of UserSettings' do
|
2017-05-30 22:28:56 +09:00
|
|
|
user = Fabricate(:user)
|
2023-03-30 21:44:00 +09:00
|
|
|
expect(user.settings).to be_a UserSettings
|
2017-05-30 22:28:56 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#setting_default_privacy' do
|
|
|
|
it 'returns default privacy setting if user has configured' do
|
|
|
|
user = Fabricate(:user)
|
|
|
|
user.settings[:default_privacy] = 'unlisted'
|
|
|
|
expect(user.setting_default_privacy).to eq 'unlisted'
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns 'private' if user has not configured default privacy setting and account is locked" do
|
2022-01-28 08:46:42 +09:00
|
|
|
user = Fabricate(:account, locked: true).user
|
2017-05-30 22:28:56 +09:00
|
|
|
expect(user.setting_default_privacy).to eq 'private'
|
|
|
|
end
|
|
|
|
|
|
|
|
it "returns 'public' if user has not configured default privacy setting and account is not locked" do
|
2022-01-28 08:46:42 +09:00
|
|
|
user = Fabricate(:account, locked: false).user
|
2017-05-30 22:28:56 +09:00
|
|
|
expect(user.setting_default_privacy).to eq 'public'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2017-04-05 00:04:44 +09:00
|
|
|
describe 'whitelist' do
|
|
|
|
around(:each) do |example|
|
2021-03-20 07:48:47 +09:00
|
|
|
old_whitelist = Rails.configuration.x.email_domains_whitelist
|
2017-04-05 00:04:44 +09:00
|
|
|
|
|
|
|
Rails.configuration.x.email_domains_whitelist = 'mastodon.space'
|
|
|
|
|
|
|
|
example.run
|
|
|
|
|
|
|
|
Rails.configuration.x.email_domains_whitelist = old_whitelist
|
|
|
|
end
|
|
|
|
|
2023-02-18 11:26:20 +09:00
|
|
|
it 'does not allow a user to be created unless they are whitelisted' do
|
2023-06-06 20:58:33 +09:00
|
|
|
user = described_class.new(email: 'foo@example.com', account: account, password: password, agreement: true)
|
2023-05-23 23:49:11 +09:00
|
|
|
expect(user).to_not be_valid
|
2017-04-05 00:04:44 +09:00
|
|
|
end
|
|
|
|
|
2023-02-18 11:26:20 +09:00
|
|
|
it 'allows a user to be created if they are whitelisted' do
|
2023-06-06 20:58:33 +09:00
|
|
|
user = described_class.new(email: 'foo@mastodon.space', account: account, password: password, agreement: true)
|
2023-05-23 23:49:11 +09:00
|
|
|
expect(user).to be_valid
|
2017-04-05 10:27:38 +09:00
|
|
|
end
|
2017-04-26 08:22:51 +09:00
|
|
|
|
2023-02-18 11:26:20 +09:00
|
|
|
it 'does not allow a user with a whitelisted top domain as subdomain in their email address to be created' do
|
2023-06-06 20:58:33 +09:00
|
|
|
user = described_class.new(email: 'foo@mastodon.space.userdomain.com', account: account, password: password, agreement: true)
|
2023-05-23 23:49:11 +09:00
|
|
|
expect(user).to_not be_valid
|
2017-04-26 08:22:51 +09:00
|
|
|
end
|
|
|
|
|
2023-06-06 22:51:42 +09:00
|
|
|
context 'with a blacklisted subdomain' do
|
2017-05-30 22:28:56 +09:00
|
|
|
around do |example|
|
|
|
|
old_blacklist = Rails.configuration.x.email_blacklist
|
|
|
|
example.run
|
|
|
|
Rails.configuration.x.email_domains_blacklist = old_blacklist
|
|
|
|
end
|
2017-04-26 08:22:51 +09:00
|
|
|
|
2023-02-18 11:26:20 +09:00
|
|
|
it 'does not allow a user to be created with a specific blacklisted subdomain even if the top domain is whitelisted' do
|
2017-05-30 22:28:56 +09:00
|
|
|
Rails.configuration.x.email_domains_blacklist = 'blacklisted.mastodon.space'
|
2017-04-26 08:22:51 +09:00
|
|
|
|
2023-06-06 20:58:33 +09:00
|
|
|
user = described_class.new(email: 'foo@blacklisted.mastodon.space', account: account, password: password)
|
2023-05-23 23:49:11 +09:00
|
|
|
expect(user).to_not be_valid
|
2017-05-30 22:28:56 +09:00
|
|
|
end
|
2017-04-26 08:22:51 +09:00
|
|
|
end
|
2017-04-05 07:29:56 +09:00
|
|
|
end
|
2017-06-05 00:07:39 +09:00
|
|
|
|
2017-08-23 01:33:57 +09:00
|
|
|
describe 'token_for_app' do
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
|
|
let(:app) { Fabricate(:application, owner: user) }
|
|
|
|
|
|
|
|
it 'returns a token' do
|
|
|
|
expect(user.token_for_app(app)).to be_a(Doorkeeper::AccessToken)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'persists a token' do
|
|
|
|
t = user.token_for_app(app)
|
|
|
|
expect(user.token_for_app(app)).to eql(t)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'is nil if user does not own app' do
|
|
|
|
app.update!(owner: nil)
|
|
|
|
|
|
|
|
expect(user.token_for_app(app)).to be_nil
|
|
|
|
end
|
|
|
|
end
|
2017-11-28 00:07:59 +09:00
|
|
|
|
2018-05-02 21:13:52 +09:00
|
|
|
describe '#disable!' do
|
|
|
|
subject(:user) { Fabricate(:user, disabled: false, current_sign_in_at: current_sign_in_at, last_sign_in_at: nil) }
|
2023-02-20 10:46:00 +09:00
|
|
|
|
2018-05-02 21:13:52 +09:00
|
|
|
let(:current_sign_in_at) { Time.zone.now }
|
|
|
|
|
|
|
|
before do
|
|
|
|
user.disable!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'disables user' do
|
2020-01-25 13:22:35 +09:00
|
|
|
expect(user).to have_attributes(disabled: true)
|
2018-05-02 21:13:52 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#enable!' do
|
|
|
|
subject(:user) { Fabricate(:user, disabled: true) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
user.enable!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'enables user' do
|
|
|
|
expect(user).to have_attributes(disabled: false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2021-07-08 12:31:28 +09:00
|
|
|
describe '#reset_password!' do
|
|
|
|
subject(:user) { Fabricate(:user, password: 'foobar12345') }
|
|
|
|
|
|
|
|
let!(:session_activation) { Fabricate(:session_activation, user: user) }
|
|
|
|
let!(:access_token) { Fabricate(:access_token, resource_owner_id: user.id) }
|
|
|
|
let!(:web_push_subscription) { Fabricate(:web_push_subscription, access_token: access_token) }
|
|
|
|
|
2024-02-14 23:15:34 +09:00
|
|
|
let(:redis_pipeline_stub) { instance_double(Redis::Namespace, publish: nil) }
|
|
|
|
|
2021-07-08 12:31:28 +09:00
|
|
|
before do
|
2024-02-14 23:15:34 +09:00
|
|
|
allow(redis).to receive(:pipelined).and_yield(redis_pipeline_stub)
|
2021-07-08 12:31:28 +09:00
|
|
|
user.reset_password!
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'changes the password immediately' do
|
|
|
|
expect(user.external_or_valid_password?('foobar12345')).to be false
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'deactivates all sessions' do
|
|
|
|
expect(user.session_activations.count).to eq 0
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'revokes all access tokens' do
|
|
|
|
expect(Doorkeeper::AccessToken.active_for(user).count).to eq 0
|
|
|
|
end
|
|
|
|
|
2024-02-14 23:15:34 +09:00
|
|
|
it 'revokes streaming access for all access tokens' do
|
|
|
|
expect(redis_pipeline_stub).to have_received(:publish).with("timeline:access_token:#{access_token.id}", Oj.dump(event: :kill)).once
|
|
|
|
end
|
|
|
|
|
2021-07-08 12:31:28 +09:00
|
|
|
it 'removes push subscriptions' do
|
|
|
|
expect(Web::PushSubscription.where(user: user).or(Web::PushSubscription.where(access_token: access_token)).count).to eq 0
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-05-02 21:13:52 +09:00
|
|
|
describe '#confirm!' do
|
|
|
|
subject(:user) { Fabricate(:user, confirmed_at: confirmed_at) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
ActionMailer::Base.deliveries.clear
|
|
|
|
user.confirm!
|
|
|
|
end
|
|
|
|
|
|
|
|
after { ActionMailer::Base.deliveries.clear }
|
|
|
|
|
|
|
|
context 'when user is new' do
|
|
|
|
let(:confirmed_at) { nil }
|
|
|
|
|
|
|
|
it 'confirms user' do
|
|
|
|
expect(user.confirmed_at).to be_present
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'delivers mails' do
|
|
|
|
expect(ActionMailer::Base.deliveries.count).to eq 2
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not new' do
|
|
|
|
let(:confirmed_at) { Time.zone.now }
|
|
|
|
|
|
|
|
it 'confirms user' do
|
|
|
|
expect(user.confirmed_at).to be_present
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not deliver mail' do
|
|
|
|
expect(ActionMailer::Base.deliveries.count).to eq 0
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe '#active_for_authentication?' do
|
|
|
|
subject { user.active_for_authentication? }
|
2023-02-20 10:46:00 +09:00
|
|
|
|
2018-05-02 21:13:52 +09:00
|
|
|
let(:user) { Fabricate(:user, disabled: disabled, confirmed_at: confirmed_at) }
|
|
|
|
|
|
|
|
context 'when user is disabled' do
|
|
|
|
let(:disabled) { true }
|
|
|
|
|
|
|
|
context 'when user is confirmed' do
|
|
|
|
let(:confirmed_at) { Time.zone.now }
|
|
|
|
|
2018-08-24 06:26:29 +09:00
|
|
|
it { is_expected.to be true }
|
2018-05-02 21:13:52 +09:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not confirmed' do
|
|
|
|
let(:confirmed_at) { nil }
|
|
|
|
|
Change unconfirmed user login behaviour (#11375)
Allow access to account settings, 2FA, authorized applications, and
account deletions to unconfirmed and pending users, as well as
users who had their accounts disabled. Suspended users cannot update
their e-mail or password or delete their account.
Display account status on account settings page, for example, when
an account is frozen, limited, unconfirmed or pending review.
After sign up, login users straight away and show a simple page that
tells them the status of their account with links to account settings
and logout, to reduce onboarding friction and allow users to correct
wrongly typed e-mail addresses.
Move the final sign-up step of SSO integrations to be the same
as above to reduce code duplication.
2019-07-22 17:48:50 +09:00
|
|
|
it { is_expected.to be true }
|
2018-05-02 21:13:52 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not disabled' do
|
|
|
|
let(:disabled) { false }
|
|
|
|
|
|
|
|
context 'when user is confirmed' do
|
|
|
|
let(:confirmed_at) { Time.zone.now }
|
|
|
|
|
|
|
|
it { is_expected.to be true }
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when user is not confirmed' do
|
|
|
|
let(:confirmed_at) { nil }
|
|
|
|
|
Change unconfirmed user login behaviour (#11375)
Allow access to account settings, 2FA, authorized applications, and
account deletions to unconfirmed and pending users, as well as
users who had their accounts disabled. Suspended users cannot update
their e-mail or password or delete their account.
Display account status on account settings page, for example, when
an account is frozen, limited, unconfirmed or pending review.
After sign up, login users straight away and show a simple page that
tells them the status of their account with links to account settings
and logout, to reduce onboarding friction and allow users to correct
wrongly typed e-mail addresses.
Move the final sign-up step of SSO integrations to be the same
as above to reduce code duplication.
2019-07-22 17:48:50 +09:00
|
|
|
it { is_expected.to be true }
|
2018-05-02 21:13:52 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2022-07-05 09:41:40 +09:00
|
|
|
|
|
|
|
describe '.those_who_can' do
|
2023-06-06 20:58:33 +09:00
|
|
|
before { Fabricate(:user, role: UserRole.find_by(name: 'Moderator')) }
|
2023-04-30 05:03:36 +09:00
|
|
|
|
|
|
|
context 'when there are not any user roles' do
|
|
|
|
before { UserRole.destroy_all }
|
|
|
|
|
|
|
|
it 'returns an empty list' do
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.those_who_can(:manage_blocks)).to eq([])
|
2023-04-30 05:03:36 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there are not users with the needed role' do
|
|
|
|
it 'returns an empty list' do
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.those_who_can(:manage_blocks)).to eq([])
|
2023-04-30 05:03:36 +09:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'when there are users with roles' do
|
|
|
|
let!(:admin_user) { Fabricate(:user, role: UserRole.find_by(name: 'Admin')) }
|
|
|
|
|
|
|
|
it 'returns the users with the role' do
|
2023-06-06 20:58:33 +09:00
|
|
|
expect(described_class.those_who_can(:manage_blocks)).to eq([admin_user])
|
2023-04-30 05:03:36 +09:00
|
|
|
end
|
|
|
|
end
|
2022-07-05 09:41:40 +09:00
|
|
|
end
|
2016-02-23 00:00:20 +09:00
|
|
|
end
|