e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
168 lines
3.5 KiB
Ruby
168 lines
3.5 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
require 'pundit/rspec'
|
|
|
|
RSpec.describe UserPolicy do
|
|
let(:subject) { described_class }
|
|
let(:admin) { Fabricate(:user, admin: true).account }
|
|
let(:john) { Fabricate(:account) }
|
|
|
|
permissions :reset_password?, :change_email? do
|
|
context 'staff?' do
|
|
context '!record.staff?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, john.user)
|
|
end
|
|
end
|
|
|
|
context 'record.staff?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, admin.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '!staff?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, User)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :disable_2fa? do
|
|
context 'admin?' do
|
|
context '!record.staff?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, john.user)
|
|
end
|
|
end
|
|
|
|
context 'record.staff?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, admin.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '!admin?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, User)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :confirm? do
|
|
context 'staff?' do
|
|
context '!record.confirmed?' do
|
|
it 'permits' do
|
|
john.user.update(confirmed_at: nil)
|
|
expect(subject).to permit(admin, john.user)
|
|
end
|
|
end
|
|
|
|
context 'record.confirmed?' do
|
|
it 'denies' do
|
|
john.user.confirm!
|
|
expect(subject).to_not permit(admin, john.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '!staff?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, User)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :enable? do
|
|
context 'staff?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, User)
|
|
end
|
|
end
|
|
|
|
context '!staff?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, User)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :disable? do
|
|
context 'staff?' do
|
|
context '!record.admin?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, john.user)
|
|
end
|
|
end
|
|
|
|
context 'record.admin?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, admin.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '!staff?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, User)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :promote? do
|
|
context 'admin?' do
|
|
context 'promoteable?' do
|
|
it 'permits' do
|
|
expect(subject).to permit(admin, john.user)
|
|
end
|
|
end
|
|
|
|
context '!promoteable?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, admin.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '!admin?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, User)
|
|
end
|
|
end
|
|
end
|
|
|
|
permissions :demote? do
|
|
context 'admin?' do
|
|
context '!record.admin?' do
|
|
context 'demoteable?' do
|
|
it 'permits' do
|
|
john.user.update(moderator: true)
|
|
expect(subject).to permit(admin, john.user)
|
|
end
|
|
end
|
|
|
|
context '!demoteable?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, john.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'record.admin?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(admin, admin.user)
|
|
end
|
|
end
|
|
end
|
|
|
|
context '!admin?' do
|
|
it 'denies' do
|
|
expect(subject).to_not permit(john, User)
|
|
end
|
|
end
|
|
end
|
|
end
|