Matt Jankowski
371f355719
Reduce .times usage in AccountStatusesCleanupPolicy ( #27947 )
2023-11-20 09:08:54 +00:00
Matt Jankowski
d2aacea8da
Reduce .times usage in AccountSearch spec, use constant for default limit ( #27946 )
2023-11-20 09:08:22 +00:00
Matt Jankowski
00c6ebd86f
Reduce .times usage in StatusPin and add PIN_LIMIT constant in validator ( #27945 )
2023-11-20 09:07:25 +00:00
Matt Jankowski
b2c5b20ef2
Fix RSpec/AnyInstance cop ( #27810 )
2023-11-14 14:52:59 +00:00
Matt Jankowski
b7807f3d84
Use normalizes to prepare Webhook#events value ( #27605 )
2023-11-13 22:47:44 +00:00
Matt Jankowski
63c9102f8a
Fix RSpec/MessageChain cop ( #27776 )
2023-11-09 12:57:23 +00:00
Matt Jankowski
69d00e2721
Fix RSpec/InstanceVariable cop ( #27766 )
2023-11-08 15:42:30 +00:00
Matt Jankowski
ce91d14d48
Fix Style/WordArray cop ( #27770 )
2023-11-08 13:03:44 +00:00
Matt Jankowski
49e2772064
Fix RSpec/MessageSpies cop ( #27751 )
2023-11-07 09:46:28 +00:00
Matt Jankowski
cfa14ec6d1
Fix Lint/EmptyBlock cop ( #27748 )
2023-11-07 09:11:04 +00:00
Matt Jankowski
b06284c572
Fix RSpec/HookArgument cop ( #27747 )
2023-11-07 09:10:36 +00:00
Matt Jankowski
949f5eb860
Fix RSpec/MetadataStyle cop in spec/ ( #27729 )
2023-11-06 14:28:20 +00:00
Claire
93e4cdc31b
Fix hashtag matching pattern matching some URLs ( #27584 )
2023-10-27 14:04:51 +00:00
Claire
bcae744275
Fix some link anchors being recognized as hashtags ( #27271 )
2023-10-23 14:19:38 +02:00
Matt Jankowski
b0213472df
Validate allowed schemes on preview card URLs ( #27485 )
2023-10-23 09:50:02 +02:00
Matt Jankowski
bcd0171e5e
Fix Lint/UselessAssignment cop ( #27472 )
2023-10-19 16:55:06 +02:00
Matt Jankowski
a1b27d8b61
Fix Naming/VariableNumber cop ( #27447 )
2023-10-18 14:26:22 +02:00
Victor Lee
c4bddc9855
Add spec for poll model ( #23399 )
...
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-10-17 14:56:24 +02:00
Claire
340c390849
Fix crash when filtering for “dormant” relationships ( #27306 )
2023-10-06 12:58:16 +02:00
Matt Jankowski
c676bc91e9
Dont match mention in url query string ( #25656 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-10-03 17:01:45 +02:00
Claire
ceb365c419
Fix boosts of local users being filtered in account timelines ( #27204 )
2023-10-03 12:21:42 +02:00
Claire
1f99d86287
Fix blocked domain appears from account feed ( #26823 )
...
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
2023-09-06 21:04:48 +02:00
Christian Schmidt
ea31929776
Fix invalid Content-Type header for WebP images ( #26773 )
2023-09-04 09:46:33 +02:00
Claire
16681e0f20
Add admin notifications for new Mastodon versions ( #26582 )
2023-09-01 17:47:07 +02:00
jsgoldstein
30c191aaa0
Add new public status index ( #26344 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-08-24 16:40:04 +02:00
Nick Schonning
b970ed6098
Update rubocop and rubocop-rspec ( #26329 )
2023-08-22 09:31:40 +02:00
Matt Jankowski
c363978782
Spec media attachment speedups ( #25416 )
2023-08-07 17:58:12 +02:00
Christian Schmidt
f2257069b2
Fix AVIF attachments ( #26264 )
2023-08-01 19:34:11 +02:00
Matt Jankowski
6f1fa1364f
Fix RSpec/EmptyExampleGroup cop ( #24735 )
2023-07-28 23:15:33 +02:00
Claire
1e3b19230a
Add stricter protocol fields validation for accounts ( #25937 )
2023-07-20 18:23:48 +02:00
Matt Jankowski
c75df62ccc
Fix RSpec/SubjectDeclaration cop ( #25312 )
2023-07-12 09:49:33 +02:00
Claire
dc8f1fbd97
Merge pull request from GHSA-9928-3cp5-93fm
...
* Fix attachments getting processed despite failing content-type validation
* Add a restrictive ImageMagick security policy tailored for Mastodon
* Fix misdetection of MP3 files with large cover art
* Reject unprocessable audio/video files instead of keeping them unchanged
2023-07-06 15:05:05 +02:00
Matt Jankowski
05f9e39b32
Fix RSpec/VerifiedDoubles cop ( #25469 )
2023-06-22 14:55:22 +02:00
Claire
dd07393e75
Fix user settings not getting validated ( #25508 )
2023-06-19 14:06:06 +01:00
Matt Jankowski
4c5aa0e470
Update rubocop-rspec to version 2.22.0, fix RSpec/IndexedLet cop ( #24698 )
2023-06-14 16:44:37 +02:00
Daniel M Brasil
d9c6f70cc6
Fix ArgumentError in /api/v1/admin/accounts/:id/action ( #25386 )
2023-06-14 15:21:36 +02:00
Matt Jankowski
ae9f5379d1
Reduce factory data created in spec/models/trends/statuses spec ( #25410 )
2023-06-14 09:57:06 +02:00
Matt Jankowski
62c996b52d
Reduce RSpec/MultipleExpectations cop max to 8 ( #25313 )
2023-06-10 18:38:22 +02:00
Matt Jankowski
c94bb9ba9a
Disable paperclip processing in specs ( #25359 )
2023-06-10 18:27:35 +02:00
Matt Jankowski
6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop ( #25310 )
2023-06-06 15:51:42 +02:00
Matt Jankowski
c42591356d
Fix RSpec/DescribedClass cop ( #25104 )
2023-06-06 13:58:33 +02:00
Matt Jankowski
b22bfae4f9
Add coverage for DomainBlock#public_domain method ( #25283 )
2023-06-06 13:34:04 +02:00
Claire
8884d1ece0
Add support for importing lists ( #25203 )
2023-06-01 14:47:31 +02:00
Matt Jankowski
d2e5430d4a
Fix RSpec/ExpectChange cop ( #25101 )
2023-05-24 11:23:40 +02:00
Matt Jankowski
b896b16cb3
Fix RSpec/PredicateMatcher cop ( #25102 )
2023-05-23 16:49:11 +02:00
Emelia Smith
19f9098551
Allow reports with long comments from remote instances, but truncate ( #25028 )
2023-05-22 13:15:21 +02:00
Nick Schonning
99e2e9b81f
Fix minor typos in comments and spec names ( #21831 )
2023-05-19 17:13:29 +02:00
Claire
3ed3d54bf3
Fix reports not being closed when performing batch suspensions ( #24988 )
2023-05-16 14:56:49 +02:00
Matt Jankowski
c97b611b6b
Fix RSpec/InferredSpecType cop ( #24736 )
2023-05-04 05:49:53 +02:00
Matt Jankowski
710745e16b
Fix RSpec/ContextWording cop ( #24739 )
2023-05-04 05:49:08 +02:00
Claire
1e75eb690d
Fix own posts not getting delivered to own lists ( #24810 )
2023-05-03 19:17:40 +02:00
Matt Jankowski
3df665fd23
Fix Lint/ConstantDefinitionInBlock cop ( #24763 )
2023-05-03 10:32:30 +02:00
Matt Jankowski
a0c9f2447e
Fix Performance/MethodObjectAsBlock cop ( #24798 )
2023-05-03 10:30:54 +02:00
Matt Jankowski
570079f8ce
Fix Performance/TimesMap cop ( #24789 )
2023-05-02 18:07:16 +02:00
Claire
6693a4fe7c
Change lists to be able to include accounts with pending follow requests ( #19727 )
2023-05-02 14:40:36 +02:00
Claire
32a030dd74
Rewrite import feature ( #21054 )
2023-05-02 12:08:48 +02:00
Matt Jankowski
274d561430
Enable local account key generation spec ( #24728 )
2023-04-30 02:28:52 +02:00
Matt Jankowski
4cfe52635c
Add pending spec for User.those_who_can ( #24724 )
2023-04-29 22:03:36 +02:00
Nick Schonning
5841f1af8c
Autofix Rubocop RSpec/MatchArray ( #24675 )
2023-04-26 21:29:36 +02:00
Nick Schonning
a3393d0d07
Autofix Rubocop RSpec/MatchArray ( #24050 )
2023-04-26 20:21:54 +02:00
Heitor de Melo Cardozo
bc75e62ca6
Change moderation search an account using the username with @ ( #24242 )
2023-04-17 14:16:36 +02:00
Christian Schmidt
b4f38edf74
Wrong type for user setting when default is defined by lambda ( #24321 )
2023-03-31 07:33:17 +02:00
Eugen Rochko
a9b5598c97
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-03-30 14:44:00 +02:00
Christian Schmidt
bd047acc35
Replace Status#translatable? with language matrix in separate endpoint ( #24037 )
2023-03-16 11:07:24 +01:00
Matt Jankowski
688287c59d
Coverage improvement round-out following up previous work ( #23987 )
2023-03-10 13:33:30 +01:00
Matt Jankowski
506b16cf59
Pending example models minimal coverage ( #23912 )
2023-03-04 17:16:45 +01:00
Matt Jankowski
cd99fa8ceb
Fabricator specs ( #23925 )
2023-03-04 17:12:09 +01:00
Matt Jankowski
c40d5e5a8f
Misc coverage improvements for validators ( #23928 )
2023-03-04 17:00:00 +01:00
Matt Jankowski
f9c2213ae5
Models specs coverage ( #23940 )
2023-03-04 16:43:47 +01:00
Christian Schmidt
5a8c651e8f
Only offer translation for supported languages ( #23879 )
2023-03-03 21:06:31 +01:00
Matt Jankowski
af578e8ce0
Fix deprecation warning about merging conditions ( #23618 )
2023-03-02 16:21:04 +01:00
Matt Jankowski
4bb39ac3c3
Fix single-record invalid condition on PollVote ( #23810 )
2023-02-27 09:31:15 +01:00
Nick Schonning
84cc805cae
Enable Style/FrozenStringLiteralComment for specs ( #23790 )
2023-02-22 09:55:31 +09:00
Nick Schonning
717683d1c3
Autofix Rubocop remaining Layout rules ( #23679 )
2023-02-20 06:58:28 +01:00
Nick Schonning
5116347eb7
Autofix Rubocop RSpec/BeEq ( #23740 )
2023-02-20 06:14:50 +01:00
Nick Schonning
bf785df9fe
Audofix Rubocop Style/WordArray ( #23739 )
2023-02-20 06:14:10 +01:00
Nick Schonning
4552685f6b
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2023-02-20 13:24:14 +09:00
Nick Schonning
38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2023-02-20 05:00:48 +01:00
Nick Schonning
bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2023-02-20 02:46:00 +01:00
Nick Schonning
65ba0d92ef
Enable Rubocop RSpec/NotToNot ( #23723 )
2023-02-20 02:33:27 +01:00
Nick Schonning
81ad6c2e39
Autofix Rubocop Style/StringLiterals ( #23695 )
2023-02-19 07:38:14 +09:00
Nick Schonning
ac3561098e
Autofix Rubocop RSpec/LetBeforeExamples ( #23671 )
2023-02-19 07:17:59 +09:00
Nick Schonning
3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2023-02-19 07:10:19 +09:00
Nick Schonning
b4cbfff3eb
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2023-02-18 12:47:37 +01:00
Nick Schonning
a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ( #23682 )
2023-02-18 04:00:05 +01:00
Nick Schonning
c0a645f647
Autofix Rubocop RSpec/ExampleWording ( #23667 )
2023-02-18 03:26:20 +01:00
Nick Schonning
54318dcd6d
Autofix Rubocop RSpec/ClassCheck ( #23685 )
2023-02-18 03:24:16 +01:00
Nick Schonning
6d42820e5d
Autofix Rubocop Lint/AmbiguousOperator ( #23680 )
2023-02-18 03:22:01 +01:00
Nick Schonning
669f6d2c0a
Run rubocop formatting except line length ( #23632 )
2023-02-18 06:56:20 +09:00
Nick Schonning
68b1071f86
Autofix Rubocop RSpec/BeNil ( #23653 )
2023-02-17 21:45:27 +09:00
Nick Schonning
0592937264
Apply Rubocop Rails/WhereNot ( #23448 )
...
* Apply Rubocop Rails/WhereNot
* Update spec for where.not
2023-02-08 10:39:57 +01:00
Nick Schonning
ed570050c6
Autofix Rails/EagerEvaluationLogMessage ( #23429 )
...
* Autofix Rails/EagerEvaluationLogMessage
* Update spec for debug block syntax
2023-02-07 03:44:36 +01:00
Claire
6883fddb19
Fix account activation being triggered before email confirmation ( #23245 )
...
* Add tests
* Fix account activation being triggered before email confirmation
Fixes #23098
2023-01-24 19:40:21 +01:00
Partho Ghosh
115ab2869b
Fix ・ detection in hashtag regex to construct hashtag correctly ( #22888 )
...
* Fix ・ detection in hashtag regex to construct hashtag correctly
* Fixed rubocop liniting issues
* More rubocop linting fix
2023-01-04 02:12:48 +01:00
Claire
70415714f1
Add follow request banner on account header ( #20785 )
...
* Add requested_by to relationship maps
* Display whether an account has requested to follow you on their profile
2022-12-15 18:50:11 +01:00
Jeong Arm
d412147d02
Save avatar or header correctly even if other one fails ( #18465 )
...
* Save avatar or header correctly if other one fails
* Fix test
2022-12-15 17:11:14 +01:00
Claire
b59fb28e90
Fix 500 error when trying to migrate to an invalid address ( #21462 )
...
* Fix 500 error when trying to migrate to an invalid address
* Add tests
2022-12-07 02:35:39 +01:00
David Leadbeater
69378eac99
Don't allow URLs that contain non-normalized paths to be verified ( #20999 )
...
* Don't allow URLs that contain non-normalized paths to be verified
This stops things like https://example.com/otheruser/../realuser where
"/otheruser" appears to be the verified URL, but the actual URL being
verified is "/realuser" due to the "/../".
Also fix a test to use 'https', so it is testing the right thing, now
that since #20304 https is required.
* missing do
2022-11-20 19:28:13 +01:00
Eugen Rochko
b31afc6294
Fix error when passing unknown filter param in REST API ( #20626 )
...
Fix #19156
2022-11-14 08:06:06 +01:00
Emily Strickland
c2231539c7
Test blank account field verifiability ( #20458 )
...
* Test blank account field verifiability
This change tests the need for #20428 , which ensures that we guard against a situation in which `at_xpath` returns `nil`.
* Test verifiability of blank fields for remote account profiles
This adds a counterpart test for remote account profiles' fields' verifiability when those fields are blank. I previously added the same test for local accounts.
2022-11-13 21:02:09 +01:00
