CloudToys/puyopuyotetr.is
1
0
Fork 0
Code

Fix empty poll options not being filtered on remote poll update (#12484)

Browse Source 
If a poll contains empty options (which is apparently possible on Pleroma),
it is created without them. However, the poll update code doesn't filter
empty options, and thus:
1. Clear known votes, as it assumes the set of options has changed
2. Errors out because it tries adding empty options, which fails validation

This commit fixes that by filtering them out the same way they are filtered
out at poll creation time.
This commit is contained in:
ThibG 2019-11-26 22:46:31 +01:00 committed by Eugen Rochko
parent e7a7f88df7
commit 00c219aa45
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/services/activitypub/process_poll_service.rb
View File

@ -30,7 +30,7 @@ class ActivityPub::ProcessPollService < BaseService
voters_count = @json['votersCount'] voters_count = @json['votersCount']
latest_options = items.map { |item| item['name'].presence || item['content'] } latest_options = items.map { |item| item['name'].presence || item['content'] }.compact
# If for some reasons the options were changed, it invalidates all previous # If for some reasons the options were changed, it invalidates all previous
# votes, so we need to remove them # votes, so we need to remove them