e38fc319dc
* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
49 lines
1.3 KiB
Ruby
49 lines
1.3 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Api::V1::Accounts::NotesController do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user) }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'write:accounts') }
|
|
let(:account) { Fabricate(:account) }
|
|
let(:comment) { 'foo' }
|
|
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
subject do
|
|
post :create, params: { account_id: account.id, comment: comment }
|
|
end
|
|
|
|
context 'when account note has reasonable length' do
|
|
let(:comment) { 'foo' }
|
|
|
|
it 'returns http success' do
|
|
subject
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'updates account note' do
|
|
subject
|
|
expect(AccountNote.find_by(account_id: user.account.id, target_account_id: account.id).comment).to eq comment
|
|
end
|
|
end
|
|
|
|
context 'when account note exceends allowed length' do
|
|
let(:comment) { 'a' * 2_001 }
|
|
|
|
it 'returns 422' do
|
|
subject
|
|
expect(response).to have_http_status(422)
|
|
end
|
|
|
|
it 'does not create account note' do
|
|
subject
|
|
expect(AccountNote.where(account_id: user.account.id, target_account_id: account.id).exists?).to be_falsey
|
|
end
|
|
end
|
|
end
|
|
end
|