1
0
REI-Fixed/spec
Claire e38fc319dc
Refactor and improve tests (#17386)
* Change account and user fabricators to simplify and improve tests

- `Fabricate(:account)` implicitly fabricates an associated `user` if
  no `domain` attribute is given (an account with `domain: nil` is
  considered a local account, but no user record was created), unless
  `user: nil` is passed
- `Fabricate(:account, user: Fabricate(:user))` should still be possible
  but is discouraged.

* Fix and refactor tests

- avoid passing unneeded attributes to `Fabricate(:user)` or
  `Fabricate(:account)`
- avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other
  way around
- prefer `Fabricate(:user, account_attributes: …)` to
  `Fabricate(:user, account: Fabricate(:account, …)`
- also, some tests were using remote accounts with local user records, which is
  not representative of production code.
2022-01-28 00:46:42 +01:00
..
controllers Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
fabricators Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
features Add submit button to the top of preferences pages (#13068) 2020-03-08 16:04:03 +01:00
fixtures Fix some link previews being incorrectly generated from other prior links (#16885) 2021-10-21 20:39:35 +02:00
helpers Add trending links (#16917) 2021-11-25 13:07:38 +01:00
lib Fix poll updates being saved as status edits (#17373) 2022-01-26 18:05:39 +01:00
mailers Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
models Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
policies Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
presenters Change references to tootsuite/mastodon to mastodon/mastodon (#16491) 2021-07-13 15:46:20 +02:00
requests Further preparation for Rails 6 (#15916) 2021-03-19 02:45:34 +01:00
routing Move create/destroy actions for api/v1/statuses to namespace (#3678) 2017-06-10 09:39:26 +02:00
serializers/activitypub Fix account URI in UpdatePollSerializer (#11194) 2019-06-27 19:41:55 +02:00
services Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
support Fix base64-encoded file uploads not being possible (#12748) 2020-01-04 01:54:07 +01:00
validators Add support for private pinned posts (#16954) 2022-01-17 00:49:55 +01:00
views Fix error when rendering public pages with media attachments (#16763) 2021-10-13 15:27:19 +02:00
workers Refactor and improve tests (#17386) 2022-01-28 00:46:42 +01:00
rails_helper.rb Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
spec_helper.rb Move rspec examples to tmp dir (#12539) 2019-12-02 19:55:08 +01:00