1
0
REI-Fixed/spec/services
Patrick Figel 8ac7fca5d0 Set correct attachment type for rejected media (#2599)
In #2110, a new attachment type "unknown" was introduced for
attachments that were rejected due to a domain being blocked using
reject_media. However, the "type" field was never set to "unknown"
because a default value of "0" (image) is set for that column,
causing the `type.blank?` expression to always equal false.

This version uses type_changed? instead, causing the type to be set
to "unknown" unless a type has been explicitly set. This introduces
a small change in behaviour causing the type to be set to unknown
before paperclip calls `before_post_process`. Presumably this
behaviour is more appropriate than the current one because the
attachment type has not been determined by that point.

Included are new tests for `ProcessFeedService` and
`UpdateRemoteProfileService` which now check that remote media is
downloaded for non-blocked domains and is rejected for others.
2017-04-29 00:18:32 +02:00
..
account_search_service_spec.rb Optimize account search (#2421) 2017-04-25 04:44:43 +02:00
authorize_follow_service_spec.rb Adding more unit tests. Fixing Salmon slaps XML 2017-02-12 17:30:15 +01:00
block_domain_service_spec.rb Domain block service cleanup (#2490) 2017-04-26 20:09:01 +02:00
block_service_spec.rb Adding more unit tests. Fixing Salmon slaps XML 2017-02-12 17:30:15 +01:00
fan_out_on_write_service_spec.rb Quick attempt to get pull requests passing 2017-04-04 12:14:44 -07:00
favourite_service_spec.rb Adding more unit tests. Fixing Salmon slaps XML 2017-02-12 17:30:15 +01:00
fetch_atom_service_spec.rb Fix #54 - Fetch remote accounts by URL from mentions 2016-09-26 16:44:40 +02:00
fetch_link_card_service_spec.rb OEmbed support for PreviewCard (#2337) 2017-04-27 14:42:22 +02:00
fetch_remote_account_service_spec.rb Fix #54 - Fetch remote accounts by URL from mentions 2016-09-26 16:44:40 +02:00
fetch_remote_status_service_spec.rb Fix #54 - Fetch remote accounts by URL from mentions 2016-09-26 16:44:40 +02:00
follow_remote_account_service_spec.rb Improve shared status verification (#2525) 2017-04-27 17:06:47 +02:00
follow_service_spec.rb Adding more unit tests. Fixing Salmon slaps XML 2017-02-12 17:30:15 +01:00
mute_service_spec.rb Mute button progress so far. WIP, doesn't entirely work correctly. 2017-03-01 22:31:21 -06:00
post_status_service_spec.rb Fix #2402 - Add Idempotency-Key header to PostStatusService that prevents (#2419) 2017-04-25 15:04:49 +02:00
precompute_feed_service_spec.rb Adding more test stubs 2016-03-19 12:13:47 +01:00
process_feed_service_spec.rb Set correct attachment type for rejected media (#2599) 2017-04-29 00:18:32 +02:00
process_interaction_service_spec.rb Stop trying to shoehorn all Salmon updates into the poor database-connected 2017-02-12 01:19:14 +01:00
process_mentions_service_spec.rb Fixing some bugs, adding pending test examples 2016-03-05 12:50:59 +01:00
reblog_service_spec.rb Removing external hub completely, fix #333 fixing digit-only hashtags, 2016-12-18 12:24:37 +01:00
reject_follow_service_spec.rb Adding more unit tests. Fixing Salmon slaps XML 2017-02-12 17:30:15 +01:00
send_interaction_service_spec.rb Fixing some bugs, adding pending test examples 2016-03-05 12:50:59 +01:00
unblock_service_spec.rb Adding more unit tests. Fixing Salmon slaps XML 2017-02-12 17:30:15 +01:00
unfollow_service_spec.rb Adding more unit tests. Fixing Salmon slaps XML 2017-02-12 17:30:15 +01:00
unmute_service_spec.rb Mute button progress so far. WIP, doesn't entirely work correctly. 2017-03-01 22:31:21 -06:00
update_remote_profile_service_spec.rb Set correct attachment type for rejected media (#2599) 2017-04-29 00:18:32 +02:00