1
0
REI-Fixed/app/assets/javascripts/components/features/ui/components
Stephen Burgess 4cfc155560 Improve aria support - Columns and Navigation Drawer Icons (#2299)
* feat(aria): Add aria-labels to underlabelled tab nav items

The drawer tabs which control primary navigation are only labelled by a title which is not available to many screenreaders. Add an aria-label attribute to each link to improve readability with screenreaders. Organize link attributes so link target is first followed by classname.
Issue #1349

* feat(aria): Replace abstract aria role of section with region

Abstract aria roles such as section should not be used in content. Use non-abstract 'region' aria role instead. That role expects an aria-labelledby attribute with an id. Pass an ID to the column header. Remove the aria-label attribute on the ColumnHeader because the same value is output in plaintext as its child.
Issue #1349

* fix(aria): Remove aria-controls attribute until solution is found

Columns do not have wrappers, so these icons can't point to a column wrapper which it controls. Instead these icons function as triggers to show or hide individual columns.
#1349

* fix(typo): Remove type of aria-labelledby instead of aria-label
2017-04-22 17:30:35 +02:00
..
boost_modal.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00
column_header.jsx Improve aria support - Columns and Navigation Drawer Icons (#2299) 2017-04-22 17:30:35 +02:00
column_link.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00
column.jsx Improve aria support - Columns and Navigation Drawer Icons (#2299) 2017-04-22 17:30:35 +02:00
columns_area.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00
media_modal.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00
modal_root.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00
onboarding_modal.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00
tabs_bar.jsx Fix TabsBar update (#2300) 2017-04-22 17:29:02 +02:00
upload_area.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00
video_modal.jsx Remove deprecated features at React v15.5 (#1905) 2017-04-21 20:05:35 +02:00